Skip to content

btrfs-progs: tune: fix the leftover csum change item and add a test case for it

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs-progs: tune: delete the csum change item after converting the fstune/change-csum.c+38 -40 replies
2/2btrfs-progs: tests/misc: add a test case for csum changetests/misc-tests/058-btrfstune-csum-change/test.sh+26 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs-progs: tune: fix the leftover csum change item and add a test case for it

David's cyclic csum change tests exposed a bug even with the latest csum change code, that I'm a total idiot and forgot to delete the csum change item.

This results a bug that if we have run multiple csum changes to the same target csum type (e.g. CRC32C->SHA256->CRC32C->SHA256), the second conversion to the same type would fail due to the left over csum change items.

This series would do the fix and add a test case to cover this bug.

Qu Wenruo (2):
btrfs-progs: tune: delete the csum change item after converting the fs
btrfs-progs: tests/misc: add a test case for csum change

 .../058-btrfstune-csum-change/test.sh         | 26 ++++++++++++
 tune/change-csum.c                            | 42 +++++++++++++++++--
 2 files changed, 64 insertions(+), 4 deletions(-)
 create mode 100755 tests/misc-tests/058-btrfstune-csum-change/test.sh
Signature · 1 line
2.40.1