Skip to content

btrfs: metadata_uuid refactors part1

Anand Jain linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 7 repliesIn review
  2. v19 patches 14 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9btrfs: reduce struct btrfs_fs_devices size relocate fsid_changefs/btrfs/volumes.h+2 -21 reply
2/9btrfs: streamline fsid checks in alloc_fs_devicesfs/btrfs/volumes.c+7 -60 replies
3/9btrfs: localise has_metadata_uuid check in alloc_fs_devices argsfs/btrfs/volumes.c+3 -60 replies
4/9btrfs: add comment about metadata_uuid in btrfs_fs_devicesfs/btrfs/volumes.h+10 -00 replies
5/9btrfs: simplify check_tree_block_fsid return arg to boolfs/btrfs/disk-io.c+4 -40 replies
6/9btrfs: refactor with match_fsid_fs_devices helperfs/btrfs/volumes.c+25 -151 reply
7/9btrfs: refactor with match_fsid_changed helperfs/btrfs/volumes.c+27 -211 reply
8/9btrfs: consolidate uuid memcmp in btrfs_validate_superfs/btrfs/disk-io.c+8 -80 replies
9/9btrfs: add and fix comments in btrfs_fs_devicesfs/btrfs/volumes.h+13 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/9] btrfs: metadata_uuid refactors part1

v2: Addressed the review comments received on some patches. Please refer
to the individual patches for more details.

The metadata_uuid feature added later has significantly impacted code readability due to the numerous conditions that need to be checked.

This patch set aims to improve code organization and prepares for streamlining of the metadata_uuid checks and some simple fixes.

Anand Jain (9):
btrfs: reduce struct btrfs_fs_devices size relocate fsid_change
btrfs: streamline fsid checks in alloc_fs_devices
btrfs: localise has_metadata_uuid check in alloc_fs_devices args
btrfs: add comment about metadata_uuid in btrfs_fs_devices
btrfs: simplify check_tree_block_fsid return arg to bool
btrfs: refactor with match_fsid_fs_devices helper
btrfs: refactor with match_fsid_changed helper
btrfs: consolidate uuid memcmp in btrfs_validate_super
btrfs: add and fix comments in btrfs_fs_devices

 fs/btrfs/disk-io.c |  24 +++++-----
 fs/btrfs/volumes.c | 110 +++++++++++++++++++++++++--------------------
 fs/btrfs/volumes.h |  37 ++++++++++-----
 3 files changed, 99 insertions(+), 72 deletions(-)
Signature · 1 line
2.38.1