Skip to content

Clean-up RT5033 charger "rt5033_charger_data" and probe "&pdev->dev"

Jakob Hauser linux-pm lkml phone-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2power: supply: rt5033_charger: Simplify initialization of rt5033_charger_datadrivers/power/supply/rt5033_charger.c+12 -170 replies
2/2power: supply: rt5033_charger: Replace "&pdev->dev" by "charger->dev" in probedrivers/power/supply/rt5033_charger.c+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Clean-up RT5033 charger "rt5033_charger_data" and probe "&pdev->dev"

During the review of the series "Add RT5033 charger device driver" [1] I noticed two things I'd like to clean up. Additionally, in v5 of that series, Christophe Jaillet pointed out an unclean error handling of function "rt5033_charger_data" [2]. The clean-up solves this as well. As I didn't want to disturb the review process of the series in its late phase, I now add these clean-ups as a follow-up series.

I was a bit surprised about the patchset "Add RT5033 charger device driver" being added via the mfd subsystem. This clean-up series affects the charger driver, which is actually part of the power supply subsystem. I'm not fully sure what the series should be based on and how it will be applied best.

Additionally I just realized that in the immutable branch "ib-mfd-power-v6.5" of kernel/git/lee/mfd.git one patch of the previous series is missing. Because of this, I currently can't use linux-next or mfd.git as a base. Instead I based this clean-up patchset right on top of the previous patchset. An instance of that base can be seen on my GitHub page [3][4].

[1] https://lore.kernel.org/linux-pm/[email protected]/T/#u
[2] https://lore.kernel.org/linux-pm/[email protected]/T/#mbe33ab528f3d8ae136f01b13f45a9be35c0ad061
[3] https://github.com/Jakko3/linux/commits/rt5033-charger_v6
[4] https://github.com/Jakko3/linux/blob/rt5033-charger_v6/drivers/power/supply/rt5033_charger.c

Jakob Hauser (2):
power: supply: rt5033_charger: Simplify initialization of

    rt5033_charger_data

power: supply: rt5033_charger: Replace "&pdev->dev" by "charger->dev"
in probe

 drivers/power/supply/rt5033_charger.c | 43 ++++++++++++---------------
 1 file changed, 19 insertions(+), 24 deletions(-)
Signature · 1 line
2.39.2