Skip to content

Q35 Support

Joel Upham xen-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 0 repliesNew
  2. v11 patch 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12libacpi: new DSDT ACPI table for Q35tools/libacpi/dsdt_q35.asl+578 -00 replies
2/12Makefile: build and use new DSDT table for Q35tools/firmware/hvmloader/Makefile tools/libacpi/Makefile+10 -20 replies
3/12hvmloader: add function to query an emulated machine type (i440/Q35)tools/firmware/hvmloader/pci_regs.h tools/firmware/hvmloader/util.c tools/firmware/hvmloader/util.h+59 -00 replies
4/12hvmloader: add ACPI enabling for Q35tools/firmware/hvmloader/hvmloader.c+11 -20 replies
5/12hvmloader: add Q35 DSDT table loadingtools/firmware/hvmloader/ovmf.c tools/firmware/hvmloader/seabios.c tools/firmware/hvmloader/util.c +1 more+23 -20 replies
6/12hvmloader: add basic Q35 supporttools/firmware/hvmloader/config.h tools/firmware/hvmloader/pci.c+104 -590 replies
7/12hvmloader: allocate MMCONFIG area in the MMIO hole + minor code refactoringtools/firmware/hvmloader/config.h tools/firmware/hvmloader/pci.c tools/firmware/hvmloader/pci_regs.h+102 -280 replies
8/12libxl: Q35 support (new option device_model_machine)tools/libs/light/libxl_dm.c tools/libs/light/libxl_types.idl tools/xl/xl_parse.c+36 -60 replies
9/12libacpi: build ACPI MCFG table if requestedtools/libacpi/acpi2_0.h tools/libacpi/build.c tools/libacpi/libacpi.h+68 -00 replies
10/12hvmloader: use libacpi to build MCFG tabletools/firmware/hvmloader/util.c+70 -00 replies
11/12docs: provide description for device_model_machine optiondocs/man/xl.cfg.5.pod.in+27 -00 replies
12/12libxl_dm: handle the new 6 port ahci controllertools/libs/light/libxl_dm.c+31 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/12] Q35 Support

Q35 support using Qemu's device emulation. I based the patches from 2017 found on the mailing list here:
https://lists.xenproject.org/archives/html/xen-devel/2018-03/msg01176.html

I have been using a version of these patches on Xen 4.16 with Qemu version 4.1 for over 6 months. The guest VMs are very stable, and PCIe PT is working as was designed (all of the PCIe devices are on the root PCIe device). I have successfully passed through GPUs, NICs, etc. I was asked by those in the community to attempt to once again upstream the patches. I have them working with Seabios and OVMF (patches are needed to OVMF which I will be sending to the mailing list). I will be sending my Qemu patches to their mailing list in hopes of getting everything upstreamed. The Qemu patches allow for the xenvbd to properly unplug the AHCI SATA device, and all xen pv windows drivers work as intended.

I used the original author of the patches to get a majority of this to work:
Alexey Gerasimenko. I fixed the patches to be in line with the upstream Qemu and Xen versions. Any original issues may still exist; however, I am sure in time they can be improved. If the code doesn't exist then they can't be actively looked at by the community.

I am not an expert on the Q35 chipset or PCIe technology. This is my first patch to this mailing list. I realized that my first patch was not properly formatted into a series, so this is the full series version.

Joel Upham (12):
libacpi: new DSDT ACPI table for Q35
Makefile: build and use new DSDT table for Q35
hvmloader: add function to query an emulated machine type (i440/Q35)
hvmloader: add ACPI enabling for Q35
hvmloader: add Q35 DSDT table loading
hvmloader: add basic Q35 support
hvmloader: allocate MMCONFIG area in the MMIO hole + minor code
refactoring
libxl: Q35 support (new option device_model_machine)
libacpi: build ACPI MCFG table if requested
hvmloader: use libacpi to build MCFG table
docs: provide description for device_model_machine option
libxl_dm: handle the new 6 port ahci controller

 docs/man/xl.cfg.5.pod.in             |  27 ++
 tools/firmware/hvmloader/Makefile    |   2 +-
 tools/firmware/hvmloader/config.h    |   6 +
 tools/firmware/hvmloader/hvmloader.c |  13 +-
 tools/firmware/hvmloader/ovmf.c      |   5 +
 tools/firmware/hvmloader/pci.c       | 285 +++++++++----
 tools/firmware/hvmloader/pci_regs.h  |   6 +
 tools/firmware/hvmloader/seabios.c   |   5 +
 tools/firmware/hvmloader/util.c      | 130 +++++-
 tools/firmware/hvmloader/util.h      |  10 +
 tools/libacpi/Makefile               |  10 +-
 tools/libacpi/acpi2_0.h              |  21 +
 tools/libacpi/build.c                |  43 ++
 tools/libacpi/dsdt_q35.asl           | 578 +++++++++++++++++++++++++++
 tools/libacpi/libacpi.h              |   4 +
 tools/libs/light/libxl_dm.c          |  60 ++-
 tools/libs/light/libxl_types.idl     |   8 +
 tools/xl/xl_parse.c                  |  14 +
 18 files changed, 1119 insertions(+), 108 deletions(-)
 create mode 100644 tools/libacpi/dsdt_q35.asl

Qemu changes in bound to their mailing list:
pc/xen: Xen Q35 support: provide IRQ handling for PCI devices pc/q35: Apply PCI bus BSEL property for Xen PCI device hotplug q35/acpi/xen: Provide ACPI PCI hotplug interface for Xen on Q35 q35/xen: Add Xen platform device support for Q35
q35: Fix incorrect values for PCIEXBAR masks
xen/pt: XenHostPCIDevice: provide functions for PCI Capabilities and
PCIe Extended Capabilities enumeration
xen/pt: avoid reading PCIe device type and cap version multiple times xen/pt: determine the legacy/PCIe mode for a passed through device xen/pt: Xen PCIe passthrough support for Q35: bypass PCIe topology
check
xen/pt: add support for PCIe Extended Capabilities and larger config
space
xen/pt: handle PCIe Extended Capabilities Next register xen/pt: allow to hide PCIe Extended Capabilities
xen/pt: add Vendor-specific PCIe Extended Capability descriptor and
sizing
xen/pt: add fixed-size PCIe Extended Capabilities descriptors xen/pt: add AER PCIe Extended Capability descriptor and sizing xen/pt: add descriptors and size calculation for
RCLD/ACS/PMUX/DPA/MCAST/TPH/DPC PCIe Extended Capabilities
xen/pt: add Resizable BAR PCIe Extended Capability descriptor and
sizing
xen/pt: add VC/VC9/MFVC PCIe Extended Capabilities descriptors and
sizing
xen/pt: Fake capability id
xen platform: unplug ahci object
pc/q35: setup q35 for xen
qdev-monitor/pt: bypass root device check
s3 support: enabling s3 with q35

 hw/acpi/ich9.c                |   22 +-
 hw/acpi/pcihp.c               |    6 +-
 hw/core/machine.c             |   19 +
 hw/i386/pc_piix.c             |    3 +-
 hw/i386/pc_q35.c              |   39 +-
 hw/i386/xen/xen-hvm.c         |    7 +-
 hw/i386/xen/xen_platform.c    |   19 +-
 hw/isa/lpc_ich9.c             |   53 +-
 hw/isa/piix3.c                |    2 +-
 hw/pci-host/q35.c             |   28 +-
 hw/pci/pci.c                  |   17 +
 hw/xen/xen-host-pci-device.c  |  106 +++-
 hw/xen/xen-host-pci-device.h  |    6 +-
 hw/xen/xen_pt.c               |   49 +-
 hw/xen/xen_pt.h               |   18 +-
 hw/xen/xen_pt_config_init.c   | 1103 ++++++++++++++++++++++++++++++---
 include/hw/acpi/pcihp.h       |    2 +
 include/hw/boards.h           |    1 +
 include/hw/i386/pc.h          |    3 +
 include/hw/pci-host/q35.h     |    4 +-
 include/hw/pci/pci.h          |    3 +
 include/hw/southbridge/ich9.h |    1 +
 include/hw/xen/xen.h          |    4 +-
 qemu-options.hx               |    1 +
 softmmu/qdev-monitor.c        |    4 +-
 stubs/xen-hw-stub.c           |    4 +-
 26 files changed, 1394 insertions(+), 130 deletions(-)
Signature · 1 line
2.34.1