Skip to content

Q35 support for Xen

Joel Upham qemu-devel xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23pc/xen: Xen Q35 support: provide IRQ handling for PCI deviceshw/i386/pc_piix.c hw/i386/xen/xen-hvm.c hw/isa/lpc_ich9.c +4 more+61 -134 replies
2/23pc/q35: Apply PCI bus BSEL property for Xen PCI device hotplughw/acpi/pcihp.c hw/pci-host/q35.c include/hw/i386/pc.h+15 -14 replies
3/23q35/acpi/xen: Provide ACPI PCI hotplug interface for Xen on Q35hw/acpi/ich9.c hw/acpi/pcihp.c include/hw/acpi/pcihp.h+13 -12 replies
4/23q35/xen: Add Xen platform device support for Q35hw/core/machine.c hw/i386/pc_q35.c include/hw/boards.h +1 more+40 -10 replies
5/23q35: Fix incorrect values for PCIEXBAR maskshw/pci-host/q35.c include/hw/pci-host/q35.h+15 -50 replies
6/23xen/pt: XenHostPCIDevice: provide functions for PCI Capabilities and PCIe Extended Capabilities enumerationhw/xen/xen-host-pci-device.c hw/xen/xen-host-pci-device.h+85 -110 replies
7/23xen/pt: avoid reading PCIe device type and cap version multiple timeshw/xen/xen-host-pci-device.c hw/xen/xen-host-pci-device.h hw/xen/xen_pt_config_init.c+30 -200 replies
8/23xen/pt: determine the legacy/PCIe mode for a passed through devicehw/xen/xen_pt.c hw/xen/xen_pt.h+27 -20 replies
9/23xen/pt: Xen PCIe passthrough support for Q35: bypass PCIe topology checkhw/xen/xen_pt_config_init.c+49 -00 replies
10/23xen/pt: add support for PCIe Extended Capabilities and larger config spacehw/xen/xen_pt.c hw/xen/xen_pt.h hw/xen/xen_pt_config_init.c+83 -300 replies
11/23xen/pt: handle PCIe Extended Capabilities Next registerhw/xen/xen_pt_config_init.c+55 -320 replies
12/23xen/pt: allow to hide PCIe Extended Capabilitieshw/xen/xen_pt.c hw/xen/xen_pt.h+14 -10 replies
13/23xen/pt: add Vendor-specific PCIe Extended Capability descriptor and sizinghw/xen/xen_pt_config_init.c+70 -10 replies
14/23xen/pt: add fixed-size PCIe Extended Capabilities descriptorshw/xen/xen_pt_config_init.c+183 -00 replies
15/23xen/pt: add AER PCIe Extended Capability descriptor and sizinghw/xen/xen_pt_config_init.c+72 -00 replies
16/23xen/pt: add descriptors and size calculation for RCLD/ACS/PMUX/DPA/MCAST/TPH/DPC PCIe Extended Capabilitieshw/xen/xen_pt_config_init.c+224 -00 replies
17/23xen/pt: add Resizable BAR PCIe Extended Capability descriptor and sizinghw/xen/xen_pt_config_init.c+28 -00 replies
18/23xen/pt: add VC/VC9/MFVC PCIe Extended Capabilities descriptors and sizinghw/xen/xen_pt_config_init.c+191 -00 replies
19/23xen/pt: Fake capability idhw/xen/xen_pt_config_init.c+71 -10 replies
20/23xen platform: unplug ahci objecthw/i386/xen/xen_platform.c hw/pci/pci.c include/hw/pci/pci.h+38 -12 replies
21/23pc/q35: setup q35 for xenhw/i386/pc_q35.c+16 -30 replies
22/23qdev-monitor/pt: bypass root device checksoftmmu/qdev-monitor.c+3 -10 replies
23/23s3 support: enabling s3 with q35hw/acpi/ich9.c hw/pci-host/q35.c+10 -52 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 00/23] Q35 support for Xen

These are the Qemu changes needed to support the q35 chipset for xen I based the patches from 2017 found on the mailing list here:
https://lists.xenproject.org/archives/html/xen-devel/2018-03/msg01176.html

I have been using a version of these patches on Xen 4.16 with Qemu version 4.1 for over 6 months. The guest VMs are very stable, and PCIe PT is working as was designed (all of the PCIe devices are on the root PCIe device). I have successfully passed through GPUs, NICs, etc. I was asked by those in the community to attempt to once again upstream the patches. I have them working with Seabios and OVMF (patches are needed to OVMF which I will be sending to the mailing list). The Qemu patches allow for the xenvbd to properly unplug the AHCI SATA device, and all xen pv windows drivers work as intended.

I used the original author of the patches to get a majority of this to work:
Alexey Gerasimenko. I fixed the patches to be in line with the upstream Qemu and Xen versions. Any original issues may still exist; however, I am sure in time they can be improved. If the code doesn't exist then they can't be actively looked at by the community.

I am not an expert on the Q35 chipset or PCIe technology. This is my first patch to this mailing list.

Joel Upham (23):
pc/xen: Xen Q35 support: provide IRQ handling for PCI devices pc/q35: Apply PCI bus BSEL property for Xen PCI device hotplug q35/acpi/xen: Provide ACPI PCI hotplug interface for Xen on Q35 q35/xen: Add Xen platform device support for Q35
q35: Fix incorrect values for PCIEXBAR masks
xen/pt: XenHostPCIDevice: provide functions for PCI Capabilities and
PCIe Extended Capabilities enumeration
xen/pt: avoid reading PCIe device type and cap version multiple times xen/pt: determine the legacy/PCIe mode for a passed through device xen/pt: Xen PCIe passthrough support for Q35: bypass PCIe topology
check
xen/pt: add support for PCIe Extended Capabilities and larger config
space
xen/pt: handle PCIe Extended Capabilities Next register xen/pt: allow to hide PCIe Extended Capabilities
xen/pt: add Vendor-specific PCIe Extended Capability descriptor and
sizing
xen/pt: add fixed-size PCIe Extended Capabilities descriptors xen/pt: add AER PCIe Extended Capability descriptor and sizing xen/pt: add descriptors and size calculation for
RCLD/ACS/PMUX/DPA/MCAST/TPH/DPC PCIe Extended Capabilities
xen/pt: add Resizable BAR PCIe Extended Capability descriptor and
sizing
xen/pt: add VC/VC9/MFVC PCIe Extended Capabilities descriptors and
sizing
xen/pt: Fake capability id
xen platform: unplug ahci object
pc/q35: setup q35 for xen
qdev-monitor/pt: bypass root device check
s3 support: enabling s3 with q35

 hw/acpi/ich9.c                |   22 +-
 hw/acpi/pcihp.c               |    6 +-
 hw/core/machine.c             |   19 +
 hw/i386/pc_piix.c             |    3 +-
 hw/i386/pc_q35.c              |   39 +-
 hw/i386/xen/xen-hvm.c         |    7 +-
 hw/i386/xen/xen_platform.c    |   19 +-
 hw/isa/lpc_ich9.c             |   53 +-
 hw/isa/piix3.c                |    2 +-
 hw/pci-host/q35.c             |   28 +-
 hw/pci/pci.c                  |   17 +
 hw/xen/xen-host-pci-device.c  |  106 +++-
 hw/xen/xen-host-pci-device.h  |    6 +-
 hw/xen/xen_pt.c               |   49 +-
 hw/xen/xen_pt.h               |   18 +-
 hw/xen/xen_pt_config_init.c   | 1103 ++++++++++++++++++++++++++++++---
 include/hw/acpi/pcihp.h       |    2 +
 include/hw/boards.h           |    1 +
 include/hw/i386/pc.h          |    3 +
 include/hw/pci-host/q35.h     |    4 +-
 include/hw/pci/pci.h          |    3 +
 include/hw/southbridge/ich9.h |    1 +
 include/hw/xen/xen.h          |    4 +-
 qemu-options.hx               |    1 +
 softmmu/qdev-monitor.c        |    4 +-
 stubs/xen-hw-stub.c           |    4 +-
 26 files changed, 1394 insertions(+), 130 deletions(-)
Signature · 1 line
2.34.1