Skip to content

Add support for Firefox's gecko profile format

Anup Sharma linux-perf-users lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 of 8 patches 1 replyIn review
  2. v46 patches 7 repliesSuperseded
  3. v36 patches 15 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches10 repliesSuperseded
v19 patches7 repliesSuperseded

Changes in v5 from the cover letter

- Reorganized the patch series to ensure that each patch works independently.
- Renamed the file to perf-gecko.py.
- Added command exection support for the script. The script can now be executed as "perf script report perf-gecko > output.json."
- Simplified the usage information; previously it was "perf script perf-gecko.py > output.json," now it is "perf script report perf-gecko > output.json."
- Merged the test and command execution patches into this series, which were previously in a separate series.

7 of 8 patches are in this archive. The cover letter announces 8.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8perf scripts python: Add initial script file with usage informationtools/perf/scripts/python/perf-gecko.py+31 -00 replies
2/8perf scripts python: Extact necessary information from process eventtools/perf/scripts/python/perf-gecko.py+13 -10 replies
3/8perf scripts python: Add classes and conversion functionstools/perf/scripts/python/perf-gecko.py+132 -10 replies
4/8perf scripts python: Add trace end processing and PRODUCT and CATEGORIES informationtools/perf/scripts/python/perf-gecko.py+64 -10 replies
5/8perf scripts python: Implement add sample function and thread processingtools/perf/scripts/python/perf-gecko.py+54 -00 replies
6/8perf scripts python: Implement add sample function and thread processingtools/perf/scripts/python/perf-gecko.py+50 -20 replies
7/8perf scripts python: Add command execution for perf gecko scripttools/perf/scripts/python/bin/perf-gecko-record tools/perf/scripts/python/bin/perf-gecko-report+5 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/8] Add support for Firefox's gecko profile format

This patch series adds support for Firefox's gecko profile format. The format is documented here [1].

I have incorporated several changes based on feedback from the previous version of the patch.

Changes in v5:
- Reorganized the patch series to ensure that each patch works independently.
- Renamed the file to perf-gecko.py.
- Added command exection support for the script. The script can now be executed as "perf script report perf-gecko > output.json."
- Simplified the usage information; previously it was "perf script perf-gecko.py > output.json," now it is "perf script report perf-gecko > output.json."
- Merged the test and command execution patches into this series, which were previously in a separate series.

Committer Testing:
- Tested with a perf.data file generated for single and multiple cpu cores enabled.
- Uploaded the stdout into profiler.firefox.com and verified the output.
- Verified the output with the output generated by the existing script as mentioned here [2].

Method:
- perf record -F 99 -a -g -- sleep 5
- perf script report perf-gecko > output.json
- upload output.json to profiler.firefox.com

[1] https://github.com/firefox-devtools/profiler/blob/main/docs-developer/gecko-profile-format.md
[2] https://perf.wiki.kernel.org/index.php/Tutorial#Firefox_Profiler

Anup Sharma (8):
perf scripts python: Add initial script file with usage information perf scripts python: Extact necessary information from process event perf scripts python: Add classes and conversion functions perf scripts python: Add trace end processing and PRODUCT and
CATEGORIES information
perf scripts python: Implement add sample function and thread
processing
perf scripts python: Implement add sample function and thread
processing
perf scripts python: Add command execution for firefox gecko converter
script
perf test: Add support for testing firefox gecko converter script

 .../perf/scripts/python/bin/perf-gecko-record |   2 +
 .../perf/scripts/python/bin/perf-gecko-report |   3 +
 tools/perf/scripts/python/perf-gecko.py       | 339 ++++++++++++++++++
 tools/perf/tests/shell/test_perf_gecko.sh     | 188 ++++++++++
 4 files changed, 532 insertions(+)
 create mode 100644 tools/perf/scripts/python/bin/perf-gecko-record
 create mode 100644 tools/perf/scripts/python/bin/perf-gecko-report
 create mode 100644 tools/perf/scripts/python/perf-gecko.py
 create mode 100755 tools/perf/tests/shell/test_perf_gecko.sh
Signature · 1 line
2.34.1