selftests: fix mptcp_join test
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 7 repliesIn review
- v12 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- Clearly state test fails only when using ip mptcp, i.e. ./mptcp_join.sh -i
- Remove test numbers from commit messages
- On endpoint delete, continue to provide $addr when id is 0.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | selftests: mptcp: join: fix 'delete and re-add' testtools/ | +1 | 0 replies | |
| 2/2 | selftests: mptcp: join: fix 'implicit EP' testtools/ | +3 | 4 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Matthieu Baerts |
|---|---|
| Series | R-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH mptcp-next v2 0/2] selftests: fix mptcp_join test
This series fixes two mptcp_join testcases when using ip mptcp:
- 'implicit EP' fails because of:
- missing iproute support for mptcp 'implicit' flag, fixed with iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit flag")
- pm_nl_check_endpoint expecting two ip addresses, while only one is
present in the iproute output;
- 'delete and re-add' fails because the endpoint delete command provide both id and ip address, while address should be provided only if id is 0.
Changelog:
v1 -> v2
- Clearly state test fails only when using ip mptcp, i.e. ./mptcp_join.sh -i
- Remove test numbers from commit messages
- On endpoint delete, continue to provide $addr when id is 0.
Andrea Claudi (2):
selftests: mptcp: join: fix 'delete and re-add' test
selftests: mptcp: join: fix 'implicit EP' test
tools/testing/selftests/net/mptcp/mptcp_join.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.41.0