Skip to content

BPF packet scheduler updates part 2

Geliang Tang mptcp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 8 repliesIn review
  2. v110 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Init nr to -1 for bpf_bkup and bpf_stale.
- Update has_bytes_sent() to make sure only one item showed in 'ss -it', this needs to start server with PORT_1.
- Rename to bpf_mptcp_subflow_memory_free() and bpf_mptcp_subflow_queues_empty().
- Simplify div_u64().
- Move mptcp_subflow_set_stale() to kernel space. stale is a bit filed, I haven't found a way to set a bit filed in BPF context yet, so set it in kernel space.
- Sync with new bpf_tcp_ca.c.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13Squash to "bpf: Add bpf_mptcp_sched_ops"net/mptcp/bpf.c+0 -270 replies
2/13Squash to "selftests/bpf: Add bpf scheduler test"tools/testing/selftests/bpf/prog_tests/mptcp.c+4 -30 replies
3/13Squash to "selftests/bpf: Add bpf_first test"tools/testing/selftests/bpf/prog_tests/mptcp.c+1 -10 replies
4/13Squash to "selftests/bpf: Add bpf_bkup scheduler"tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c+3 -20 replies
5/13Squash to "selftests/bpf: Add bpf_bkup test"tools/testing/selftests/bpf/prog_tests/mptcp.c+1 -10 replies
6/13Squash to "selftests/bpf: Add bpf_rr test"tools/testing/selftests/bpf/prog_tests/mptcp.c+1 -10 replies
7/13Squash to "selftests/bpf: Add bpf_red test"tools/testing/selftests/bpf/prog_tests/mptcp.c+1 -10 replies
8/13mptcp: add subflow_set_stale helpernet/mptcp/bpf.c net/mptcp/protocol.h net/mptcp/sched.c+9 -03 replies
9/13selftests/bpf: Add bpf_stale schedulertools/testing/selftests/bpf/bpf_tcp_helpers.h tools/testing/selftests/bpf/progs/mptcp_bpf_stale.c+65 -10 replies
10/13selftests/bpf: Add bpf_stale testtools/testing/selftests/bpf/prog_tests/mptcp.c+38 -00 replies
11/13bpf: Export more bpf_burst related functionsnet/mptcp/bpf.c net/mptcp/protocol.c net/mptcp/protocol.h+22 -21 reply
12/13selftests/bpf: Add bpf_burst schedulertools/testing/selftests/bpf/bpf_tcp_helpers.h tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c+201 -00 replies
13/13selftests/bpf: Add bpf_burst testtools/testing/selftests/bpf/prog_tests/mptcp.c+38 -02 replies

Reviews trailers per patch

1 of 13 patches has a Reviewed-by or Acked-by.

PatchMat Martineau
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13R-b
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH mptcp-next v2 00/13] BPF packet scheduler updates part 2

v2:
- Init nr to -1 for bpf_bkup and bpf_stale.
- Update has_bytes_sent() to make sure only one item showed in 'ss -it', this needs to start server with PORT_1.
- Rename to bpf_mptcp_subflow_memory_free() and bpf_mptcp_subflow_queues_empty().
- Simplify div_u64().
- Move mptcp_subflow_set_stale() to kernel space. stale is a bit filed, I haven't found a way to set a bit filed in BPF context yet, so set it in kernel space.
- Sync with new bpf_tcp_ca.c.

Geliang Tang (13):
Squash to "bpf: Add bpf_mptcp_sched_ops" Squash to "selftests/bpf: Add bpf scheduler test" Squash to "selftests/bpf: Add bpf_first test" Squash to "selftests/bpf: Add bpf_bkup scheduler" Squash to "selftests/bpf: Add bpf_bkup test" Squash to "selftests/bpf: Add bpf_rr test" Squash to "selftests/bpf: Add bpf_red test"
mptcp: add subflow_set_stale helper selftests/bpf: Add bpf_stale scheduler selftests/bpf: Add bpf_stale test
bpf: Export more bpf_burst related functions selftests/bpf: Add bpf_burst scheduler selftests/bpf: Add bpf_burst test

 net/mptcp/bpf.c                               |  44 ++--
 net/mptcp/protocol.c                          |   4 +-
 net/mptcp/protocol.h                          |   6 +
 net/mptcp/sched.c                             |   6 +
 tools/testing/selftests/bpf/bpf_tcp_helpers.h |   7 +-
 .../testing/selftests/bpf/prog_tests/mptcp.c  |  91 +++++++-
 .../selftests/bpf/progs/mptcp_bpf_bkup.c      |   5 +-
 .../selftests/bpf/progs/mptcp_bpf_burst.c     | 197 ++++++++++++++++++
 .../selftests/bpf/progs/mptcp_bpf_stale.c     |  63 ++++++
 9 files changed, 384 insertions(+), 39 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_stale.c
Signature · 1 line
2.35.3