Skip to content

bpf: Force to MPTCP

Geliang Tang bpf linux-kselftest linux-security-module mptcp netdev selinux 14 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v14 Latest4 patches 3 repliesApplied 4/4
  2. v134 patches 3 repliesSuperseded
  3. v125 patches 0 repliesSuperseded
Earlier versions · 11
VersionPostedPatchesRepliesStatus
v115 patches11 repliesSuperseded
v105 patches3 repliesSuperseded
v94 patches7 repliesSuperseded
v84 patches5 repliesSuperseded
v7 RFC6 patches5 repliesSuperseded
v6 RFC1 patch1 replySuperseded
v5 RFC1 patch6 repliesSuperseded
v47 patches3 repliesSuperseded
v35 patches1 replySuperseded
v24 patches1 replySuperseded
v14 patches10 repliesSuperseded

Changes in v14 from the cover letter

- Use getsockopt(MPTCP_INFO) to verify mptcp protocol intead of using
nstat command.

Patches in v14 All 4 applied

#Subject and filesSizeRepliesApplied
1/4bpf: Add update_socket_protocol hooknet/mptcp/bpf.c net/socket.c+40 -12 repliesApplied
2/4selftests/bpf: Add two mptcp netns helperstools/testing/selftests/bpf/prog_tests/mptcp.c+21 -100 repliesApplied
3/4selftests/bpf: Fix error checks of mptcp open_and_loadtools/testing/selftests/bpf/prog_tests/mptcp.c+1 -110 repliesApplied
4/4selftests/bpf: Add mptcpify testtools/testing/selftests/bpf/prog_tests/mptcp.c tools/testing/selftests/bpf/progs/mptcpify.c+136 -01 replyApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMatthieu BaertsYonghong Song
1/4A-b A-b
2/4R-b A-b
3/4A-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v14 thread

Cover letter [PATCH bpf-next v14 0/4] bpf: Force to MPTCP

As is described in the "How to use MPTCP?" section in MPTCP wiki [1]:

"Your app should create sockets with IPPROTO_MPTCP as the proto:
( socket(AF_INET, SOCK_STREAM, IPPROTO_MPTCP); ). Legacy apps can be forced to create and use MPTCP sockets instead of TCP ones via the mptcpize command bundled with the mptcpd daemon."

But the mptcpize (LD_PRELOAD technique) command has some limitations [2]:

- it doesn't work if the application is not using libc (e.g. GoLang
apps)
- in some envs, it might not be easy to set env vars / change the way
apps are launched, e.g. on Android
- mptcpize needs to be launched with all apps that want MPTCP: we could
have more control from BPF to enable MPTCP only for some apps or all the ones of a netns or a cgroup, etc.
- it is not in BPF, we cannot talk about it at netdev conf.

So this patchset attempts to use BPF to implement functions similer to mptcpize.

The main idea is to add a hook in sys_socket() to change the protocol id from IPPROTO_TCP (or 0) to IPPROTO_MPTCP.

[1]
https://github.com/multipath-tcp/mptcp_net-next/wiki
[2]
https://github.com/multipath-tcp/mptcp_net-next/issues/79

v14:
- Use getsockopt(MPTCP_INFO) to verify mptcp protocol intead of using
nstat command.

v13:
- drop "Use random netns name for mptcp" patch.

v12:
- update diag_* log of update_socket_protocol.
- add 'ip netns show' after 'ip netns del' to check if there is
a test did not clean up its netns.
- return libbpf_get_error() instead of -EIO for the error from
open_and_load().
- Use getsockopt(SOL_PROTOCOL) to verify mptcp protocol intead of
using 'ss -tOni'.

v11:
- add comments about outputs of 'ss' and 'nstat'.
- use "err = verify_mptcpify()" instead of using =+.

v10:
- drop "#ifdef CONFIG_BPF_JIT".
- include vmlinux.h and bpf_tracing_net.h to avoid defining some
macros.
- drop unneeded checks for mptcp.

v9:
- update comment for 'update_socket_protocol'.

v8:
- drop the additional checks on the 'protocol' value after the
'update_socket_protocol()' call.

v7:
- add __weak and __diag_* for update_socket_protocol.

v6:
- add update_socket_protocol.

v5:
- add bpf_mptcpify helper.

v4:
- use lsm_cgroup/socket_create

v3:
- patch 8: char cmd[128]; -> char cmd[256];

v2:
- Fix build selftests errors reported by CI

Geliang Tang (4):
bpf: Add update_socket_protocol hook selftests/bpf: Add two mptcp netns helpers selftests/bpf: Fix error checks of mptcp open_and_load selftests/bpf: Add mptcpify test

 net/mptcp/bpf.c                               |  15 ++
 net/socket.c                                  |  26 ++-
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 155 +++++++++++++++---
 tools/testing/selftests/bpf/progs/mptcpify.c  |  20 +++
 4 files changed, 196 insertions(+), 20 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcpify.c
Signature · 1 line
2.35.3