watchdog: iTCO_wdt: Backport patches to enable handle_boot_enabled=0
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | watchdog: iTCO_wdt: No need to stop the timer in probedrivers/ | +11 | 0 replies | |
| 2/2 | watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already runningdrivers/ | +14 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Guenter Roeck | Daniel P. Berrangé |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | R-b | T-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 5.10.y-cip 0/2] watchdog: iTCO_wdt: Backport patches to enable handle_boot_enabled=0
These patches are needed in order to make iTCO_wdt respect handle_boot_enabled=0, i.e. to step back from a running watchdog until userspace picks it up. Up to 5.16, the driver simply stopped the watchdog which could have created a non-monitored window during boot-up in the handover from the firmware starting it to userspace (typically sytemd) safely driving. E.g., any infinite loops in the initramfs would could have created a locked-up system.
These patches were proposed to the watchdog maintainers for official stable integration [1] but received no reaction so far. As the issue is critical for CIP's OTA software update integration, let's use the CIP path instead.
I don't have any test setup for 4.19, so I'm only proposing this for 5.10 here.
Jan
[1] https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
Mika Westerberg (2):
watchdog: iTCO_wdt: No need to stop the timer in probe
watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already
running
drivers/watchdog/iTCO_wdt.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-)
Signature · 1 line
2.35.3