Skip to content

commit-graph: avoid looking at Bloom filter data directly

Taylor Blau git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4t/helper/test-read-graph.c: extract `dump_graph_info()`t/helper/test-read-graph.c+20 -130 replies
2/4bloom.h: make `load_bloom_filter_from_graph()` publicbloom.c bloom.h+8 -30 replies
3/4t/helper/test-read-graph: implement `bloom-filters` modet/helper/test-read-graph.c+37 -50 replies
4/4fixup! t4216: test changed path filters with high bit pathst/t4216-log-bloom.sh+3 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] commit-graph: avoid looking at Bloom filter data directly

Hi Jonathan,

Here's a few commits (and one fixup!) that could go before the second patch of your series, with the fixup! getting squashed into the second patch itself.

The first three are preparatory, but the fourth patch should allow us to drop the Perl hackery necessary to dump the raw contents of arbitrary Bloom filters.

Feel free to pick up these patches (or not), just wanted to get these out there as a possible suggestion.

Taylor Blau (4):
t/helper/test-read-graph.c: extract dump_graph_info() bloom.h: make load_bloom_filter_from_graph() public t/helper/test-read-graph: implement bloom-filters mode fixup! t4216: test changed path filters with high bit paths

 bloom.c                    |  6 ++--
 bloom.h                    |  5 +++
 t/helper/test-read-graph.c | 67 ++++++++++++++++++++++++++++++--------
 t/t4216-log-bloom.sh       | 14 ++------
 4 files changed, 64 insertions(+), 28 deletions(-)

--
2.41.0.366.g215419bf3c2.dirty