RFC btrfs: make extent buffer memory continuous
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: map uncontinuous extent buffer pages into virtual address spacefs/ fs/ | +77 | 3 replies | |
| 2/2 | btrfs: utilize the physically/virtually continuous extent buffer memoryfs/ fs/ fs/ | +42 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RFC 0/2] btrfs: make extent buffer memory continuous
[REPO]
https://github.com/adam900710/linux/tree/eb_page_cleanups
This includes the submitted extent buffer accessors cleanup as the dependency.
[BACKGROUND]
We have a lot of extent buffer code addressing the cross-page accesses, on the other hand, other filesystems like XFS is mapping its xfs_buf into kernel virtual address space, so that they can access the content of xfs_buf without bothering the page boundaries.
[OBJECTIVE]
This patchset is mostly learning from the xfs_buf, to greatly simplify the extent buffer accessors.
Now all the extent buffer accessors are turned into wrappers of memcpy()/memcmp()/memmove().
For now, it can pass test cases from btrfs test case without new regressions.
[RFC]
But I still want to get more feedbacks on this topic, since it's changing the very core of btrfs extent buffer.
Furthermore, this change may not be 32bit systems friendly, as kernel virtual address space is only 128MiB for 32bit systems, not sure if it's going to cause any regression on 32bit systems.
[TODO]
- Benchmarks
I'm not 100% sure if this going to cause any performance change. In theory, we off-load the cross-page handling to hardware MMU, which should improve performance, but we spend more time initializing the extent buffer.
- More tests on 32bit and 64bit systems
Qu Wenruo (2):
btrfs: map uncontinuous extent buffer pages into virtual address space
btrfs: utilize the physically/virtually continuous extent buffer
memory
fs/btrfs/disk-io.c | 18 +-- fs/btrfs/extent_io.c | 303 ++++++++++++++----------------------------- fs/btrfs/extent_io.h | 17 +++ 3 files changed, 119 insertions(+), 219 deletions(-)
Signature · 1 line
2.41.0