Skip to content

mlxsw: Speed up transceiver module EEPROM dump

Petr Machata netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesApplied 5/5

Patches in v1 All 5 applied

#Subject and filesSizeRepliesApplied
1/5mlxsw: reg: Move 'mpsc' definition in 'mlxsw_reg_infos'drivers/net/ethernet/mellanox/mlxsw/reg.h+1 -10 repliesApplied
2/5mlxsw: reg: Add Management Capabilities Mask Registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+74 -00 repliesApplied
3/5mlxsw: reg: Remove unused function argumentdrivers/net/ethernet/mellanox/mlxsw/core_env.c drivers/net/ethernet/mellanox/mlxsw/reg.h+6 -160 repliesApplied
4/5mlxsw: reg: Increase Management Cable Info Access Register lengthdrivers/net/ethernet/mellanox/mlxsw/reg.h+1 -10 repliesApplied
5/5mlxsw: core_env: Read transceiver module EEPROM in 128 bytes chunksdrivers/net/ethernet/mellanox/mlxsw/core_env.c drivers/net/ethernet/mellanox/mlxsw/reg.h+30 -80 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPetr Machata
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/5] mlxsw: Speed up transceiver module EEPROM dump

Ido Schimmel writes:

Old firmware versions could only read up to 48 bytes from a transceiver module's EEPROM in one go. Newer versions can read up to 128 bytes, resulting in fewer transactions.

Query support for the new capability during driver initialization and if supported, read up to 128 bytes in one go.

This is going to be especially useful for upcoming transceiver module firmware flashing support.

Before:

 # perf stat -e devlink:devlink_hwmsg -- ethtool -m swp11 page 0x1 offset 128 length 128 i2c 0x50
 [...]
  Performance counter stats for 'ethtool -m swp11 page 0x1 offset 128 length 128 i2c 0x50':

3 devlink:devlink_hwmsg

After:

 # perf stat -e devlink:devlink_hwmsg -- ethtool -m swp11 page 0x1 offset 128 length 128 i2c 0x50
 [...]
  Performance counter stats for 'ethtool -m swp11 page 0x1 offset 128 length 128 i2c 0x50':

1 devlink:devlink_hwmsg

Patches #1-#4 are preparations / cleanups.

Patch #5 adds support for the new read size.

Amit Cohen (2):
mlxsw: reg: Move 'mpsc' definition in 'mlxsw_reg_infos'
mlxsw: reg: Add Management Capabilities Mask Register

Ido Schimmel (3):
mlxsw: reg: Remove unused function argument
mlxsw: reg: Increase Management Cable Info Access Register length
mlxsw: core_env: Read transceiver module EEPROM in 128 bytes chunks

 .../net/ethernet/mellanox/mlxsw/core_env.c    | 45 ++++++---
 drivers/net/ethernet/mellanox/mlxsw/reg.h     | 93 ++++++++++++++++---
 2 files changed, 112 insertions(+), 26 deletions(-)
Signature · 1 line
2.41.0