Skip to content

Additional tests for ISO and hci_sync

Pauli Virtanen linux-bluetooth 2 versions – Applied

Status from this message: This series was applied to bluetooth/bluez.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyApplied
  2. v15 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- emit correct event from HCI_Create_Connection_Cancel + fix compile

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5btdev: check error conditions for HCI_Create_Connection_Cancelemulator/btdev.c monitor/bt.h+79 -111 reply
2/5btdev: fix Command Status command opcodes for Setup Sync Connemulator/btdev.c+2 -20 replies
3/5sco-tester: test local and remote disconnecting simultaneouslytools/sco-tester.c+59 -00 replies
4/5iso-tester: test with large CIS_ID and invalid CIG_ID/CIS_IDtools/iso-tester.c+72 -00 replies
5/5iso-tester: add tests checking Remove CIG is emittedtools/iso-tester.c+96 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH BlueZ v2 0/5] Additional tests for ISO and hci_sync

This adds a few tests checking ISO socket handling of invalid input parameters and cleanup in some race conditions:

    ISO QoS CIG 0xF0 - Invalid
    ISO QoS CIS 0xF0 - Invalid
    ISO Connect2 CIG 0x01 - Success/Invalid
    ISO AC 6(ii) CIS 0xEF/auto - Success
    ISO AC 6(ii) CIS 0xEF/0xEF - Invalid
    ISO Defer Close - Success
    ISO Connect Close - Success
    ISO Defer Wait Close - Success
    ISO Connect Wait Close - Success

There's also one for a hci_sync race condition that triggers GPF:

eSCO Simultaneous Disconnect - Failure

I have a patch series fixing these, but we'll revisit the HCI_CONN_DELETED flag there, so maybe discussion needed.

These fail on current bluetooth-next/master, so it could make most sense to wait for the fixes first.

v2:
- emit correct event from HCI_Create_Connection_Cancel + fix compile

Pauli Virtanen (5):
btdev: check error conditions for HCI_Create_Connection_Cancel
btdev: fix Command Status command opcodes for Setup Sync Conn
sco-tester: test local and remote disconnecting simultaneously
iso-tester: test with large CIS_ID and invalid CIG_ID/CIS_ID
iso-tester: add tests checking Remove CIG is emitted

 emulator/btdev.c   |  90 ++++++++++++++++++++----
 monitor/bt.h       |   4 ++
 tools/iso-tester.c | 168 +++++++++++++++++++++++++++++++++++++++++++++
 tools/sco-tester.c |  59 ++++++++++++++++
 4 files changed, 308 insertions(+), 13 deletions(-)
Signature · 1 line
2.41.0