mlxsw: Avoid non-tracker helpers when holding and putting netdevices
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mlxsw: spectrum: Drop unused functions mlxsw_sp_port_lower_dev_hold/_put()drivers/ drivers/ | +0 | 0 replies | Applied |
| 2/7 | mlxsw: spectrum_nve: Do not take reference when looking up netdevicedrivers/ | +4 | 0 replies | Applied |
| 3/7 | mlxsw: spectrum_switchdev: Use tracker helpers to hold & put netdevicesdrivers/ | +5 | 0 replies | Applied |
| 4/7 | mlxsw: spectrum_router: FIB: Use tracker helpers to hold & put netdevicesdrivers/ | +5 | 0 replies | Applied |
| 5/7 | mlxsw: spectrum_router: hw_stats: Use tracker helpers to hold & put netdevicesdrivers/ | +3 | 0 replies | Applied |
| 6/7 | mlxsw: spectrum_router: RIF: Use tracker helpers to hold & put netdevicesdrivers/ | +4 | 0 replies | Applied |
| 7/7 | mlxsw: spectrum_router: IPv6 events: Use tracker helpers to hold & put netdevicesdrivers/ | +3 | 0 replies | Applied |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ido Schimmel | Eric Dumazet |
|---|---|---|
| Series | R-b | |
| 1/7 | R-b | |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 0/7] mlxsw: Avoid non-tracker helpers when holding and putting netdevices
Using the tracking helpers, netdev_hold() and netdev_put(), makes it easier to debug netdevice refcount imbalances when CONFIG_NET_DEV_REFCNT_TRACKER is enabled. For example, the following traceback shows the callpath to the point of an outstanding hold that was never put:
unregister_netdevice: waiting for swp3 to become free. Usage count = 6
ref_tracker: eth%d@ffff888123c9a580 has 1/5 users at
mlxsw_sp_switchdev_event+0x6bd/0xcc0 [mlxsw_spectrum]
notifier_call_chain+0xbf/0x3b0
atomic_notifier_call_chain+0x78/0x200
br_switchdev_fdb_notify+0x25f/0x2c0 [bridge]
fdb_notify+0x16a/0x1a0 [bridge]
[...]In this patchset, get rid of all non-ref-tracking helpers in mlxsw.
- Patch #1 drops two functions that are not used anymore, but contain dev_hold() / dev_put() calls.
- Patch #2 avoids taking a reference in one function which is called under RTNL.
- The remaining patches convert individual hold/put sites one by one from trackerless to tracker-enabled.
Petr Machata (7):
mlxsw: spectrum: Drop unused functions
mlxsw_sp_port_lower_dev_hold/_put()
mlxsw: spectrum_nve: Do not take reference when looking up netdevice
mlxsw: spectrum_switchdev: Use tracker helpers to hold & put
netdevices
mlxsw: spectrum_router: FIB: Use tracker helpers to hold & put
netdevices
mlxsw: spectrum_router: hw_stats: Use tracker helpers to hold & put
netdevices
mlxsw: spectrum_router: RIF: Use tracker helpers to hold & put
netdevices
mlxsw: spectrum_router: IPv6 events: Use tracker helpers to hold & put
netdevices
.../net/ethernet/mellanox/mlxsw/spectrum.c | 17 ------------- .../net/ethernet/mellanox/mlxsw/spectrum.h | 2 -- .../ethernet/mellanox/mlxsw/spectrum_nve.c | 7 +++--- .../ethernet/mellanox/mlxsw/spectrum_router.c | 25 +++++++++++-------- .../mellanox/mlxsw/spectrum_switchdev.c | 9 ++++--- 5 files changed, 24 insertions(+), 36 deletions(-)
Signature · 1 line
2.41.0