Skip to content

metadata_uuid misc cleanup and fixes part2

Anand Jain linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 13 repliesIn review
  2. v14 patches 5 repliesSuperseded

Changes in v2 from the cover letter

The new patch 1/7 peels btrfs_sb_fsid_prt() helper function from 1/4 in v1, This function is used in patch 2/7 and patch 4/7 in v2.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7btrfs: add a helper to read the superblock metadata_uuidfs/btrfs/volumes.c fs/btrfs/volumes.h+9 -02 replies
2/7btrfs: simplify memcpy either of metadata_uuid or fsidfs/btrfs/volumes.c+2 -91 reply
3/7btrfs: fix fsid in btrfs_validate_superfs/btrfs/disk-io.c+2 -32 replies
4/7btrfs: fix metadata_uuid in btrfs_validate_superfs/btrfs/disk-io.c+3 -51 reply
5/7btrfs: drop redundant check to use fs_devices::metadata_uuidfs/btrfs/disk-io.c+5 -101 reply
6/7btrfs: add a superblock helper to read metadata_uuid or NULLfs/btrfs/volumes.c+8 -02 replies
7/7btrfs: use btrfs_sb_metadata_uuid_or_nullfs/btrfs/volumes.c+1 -12 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchJohannes ThumshirnGuilherme G. Piccoli
SeriesT-b
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/7 v2] metadata_uuid misc cleanup and fixes part2

v2:
The new patch 1/7 peels btrfs_sb_fsid_prt() helper function from 1/4 in v1, This function is used in patch 2/7 and patch 4/7 in v2.

Patch 6/7, adds btrfs_sb_metadata_uuid_or_null() another helper func, used in 7/7 in volumes.c. Further, used in the upcoming fsid_changing patch. Pushing this set now which are ready. This has passed fstests -g quick.

----- original -----
These patches are cleanups related to metadata_uuid. Please ref to the patch for details.

Anand Jain (7):
btrfs: add a helper to read the superblock metadata_uuid
btrfs: simplify memcpy either of metadata_uuid or fsid
btrfs: fix fsid in btrfs_validate_super
btrfs: fix metadata_uuid in btrfs_validate_super
btrfs: drop redundant check to use fs_devices::metadata_uuid
btrfs: add a superblock helper to read metadata_uuid or NULL
btrfs: use btrfs_sb_metadata_uuid_or_null

 fs/btrfs/disk-io.c | 28 ++++++++++------------------
 fs/btrfs/volumes.c | 29 +++++++++++++++++++----------
 fs/btrfs/volumes.h |  1 +
 3 files changed, 30 insertions(+), 28 deletions(-)
Signature · 1 line
2.39.2