Skip to content

clk: keystone: syscon-clk: fixes for audio refclk

Matthias Schiffer linux-clk lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3clk: keystone: syscon-clk: use struct instead of array for match datadrivers/clk/keystone/syscon-clk.c+34 -210 replies
2/3clk: keystone: syscon-clk: specify whether a parent is required in match datadrivers/clk/keystone/syscon-clk.c+3 -30 replies
3/3clk: keystone: syscon-clk: use of_clk_hw_simple_get() for audio refclkdrivers/clk/keystone/syscon-clk.c+12 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] clk: keystone: syscon-clk: fixes for audio refclk

Currently the driver uses of_clk_hw_onecell_get() for all clocks it manages, but this is incorrect for the audio refclk, which has 0 rather than 1 clock cell according to its binding documentation [1]; attempting to look up the clock when referenced like this in the Device Tree leads to errors, as uninitialized memory is passed to of_clk_hw_onecell_get() as the index.

The actual fix is in patch 3; patches 1 and 2 are preparation and related cleanup. I've added a Fixes: tag to all 3 patches, as they need to be backported together.

Matthias Schiffer (3):
clk: keystone: syscon-clk: use struct instead of array for match data
clk: keystone: syscon-clk: specify whether a parent is required in
match data
clk: keystone: syscon-clk: use of_clk_hw_simple_get() for audio refclk

[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml

 drivers/clk/keystone/syscon-clk.c | 73 ++++++++++++++++++++-----------
 1 file changed, 48 insertions(+), 25 deletions(-)
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/