Skip to content

x86: address some violations of MISRA C:2012 Rule 5.3

Nicola Vetrini xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 13 repliesIn review
  2. v14 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Addressed comments on patches 1 and 2. Patches 3 and 4 are unchanged.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86/mce: address MISRA C:2012 Rule 5.3xen/arch/x86/cpu/mcheck/barrier.c xen/arch/x86/cpu/mcheck/barrier.h+11 -112 replies
2/4x86/mtrr: address MISRA C:2012 Rule 5.3xen/arch/x86/hvm/mtrr.c+16 -163 replies
3/4x86/irq: rename variable to address MISRA C:2012 Rule 5.3xen/arch/x86/hvm/hvm.c xen/arch/x86/include/asm/irq.h xen/arch/x86/io_apic.c +3 more+16 -163 replies
4/4x86/setup: address MISRA C:2012 Rule 5.3xen/arch/x86/include/asm/setup.h xen/arch/x86/setup.c+2 -35 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchStefano StabelliniJan Beulich
1/4R-b A-b
2/4R-b A-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [XEN PATCH v2 0/4] x86: address some violations of MISRA C:2012 Rule 5.3

Some variables are renamed or deleted in this series to avoid shadowing, which violates MISRA C:2012 Rule 5.3, whose headline is:
"An identifier declared in an inner scope shall not hide an identifier declared in an outer scope".

---
Changes in v2:
- Addressed comments on patches 1 and 2. Patches 3 and 4 are unchanged.

Nicola Vetrini (4):
x86/mce: address MISRA C:2012 Rule 5.3
x86/mtrr: address MISRA C:2012 Rule 5.3
x86/irq: rename variable to address MISRA C:2012 Rule 5.3 x86/setup: address MISRA C:2012 Rule 5.3

 xen/arch/x86/cpu/mcheck/barrier.c |  8 ++++----
 xen/arch/x86/cpu/mcheck/barrier.h | 14 +++++++-------
 xen/arch/x86/hvm/hvm.c            |  2 +-
 xen/arch/x86/hvm/mtrr.c           | 32 +++++++++++++++----------------
 xen/arch/x86/include/asm/irq.h    |  2 +-
 xen/arch/x86/include/asm/setup.h  |  2 +-
 xen/arch/x86/io_apic.c            | 10 +++++-----
 xen/arch/x86/irq.c                | 12 ++++++------
 xen/arch/x86/msi.c                |  4 ++--
 xen/arch/x86/setup.c              |  3 +--
 xen/include/xen/irq.h             |  2 +-
 11 files changed, 45 insertions(+), 46 deletions(-)

--
2.34.1