Skip to content

serial: cpm_uart: Cleanup and refactoring

Christophe Leroy linux-serial linuxppc-dev lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12serial: cpm_uart: Avoid suspicious lockingdrivers/tty/serial/cpm_uart/cpm_uart_core.c+4 -90 replies
2/12serial: cpm_uart: Remove stale prototypes and table and macrosdrivers/tty/serial/cpm_uart/cpm_uart.h drivers/tty/serial/cpm_uart/cpm_uart_core.c+1 -240 replies
3/12serial: cpm_uart: Stop using fs_uart_id enumdrivers/tty/serial/cpm_uart/cpm_uart.h drivers/tty/serial/cpm_uart/cpm_uart_core.c+1 -30 replies
4/12serial: cpm_uart: Use get_baudrate() instead of uart_baudrate()arch/powerpc/include/asm/fs_pd.h drivers/tty/serial/cpm_uart/cpm_uart_core.c+4 -120 replies
5/12serial: cpm_uart: Deduplicate cpm_set_{brg/smc_fcr/scc_fcr}()drivers/tty/serial/cpm_uart/cpm_uart.h drivers/tty/serial/cpm_uart/cpm_uart_core.c drivers/tty/serial/cpm_uart/cpm_uart_cpm1.h +1 more+9 -710 replies
6/12serial: cpm_uart: Deduplicate cpm_line_cr_cmd()drivers/tty/serial/cpm_uart/cpm_uart.h drivers/tty/serial/cpm_uart/cpm_uart_core.c drivers/tty/serial/cpm_uart/cpm_uart_cpm1.c +1 more+5 -110 replies
7/12serial: cpm_uart: Refactor cpm_uart_allocbuf()/cpm_uart_freebuf()drivers/tty/serial/cpm_uart/cpm_uart.h drivers/tty/serial/cpm_uart/cpm_uart_core.c drivers/tty/serial/cpm_uart/cpm_uart_cpm1.c +1 more+72 -1400 replies
8/12serial: cpm_uart: Refactor cpm_uart_[un]map_pram()drivers/tty/serial/cpm_uart/Makefile drivers/tty/serial/cpm_uart/cpm_uart.h drivers/tty/serial/cpm_uart/cpm_uart_core.c +2 more+49 -1420 replies
9/12serial: cpm_uart: Remove cpm_uart/ subdirectorydrivers/tty/serial/Makefile drivers/tty/serial/cpm_uart.c drivers/tty/serial/cpm_uart.h +1 more+1 -70 replies
10/12serial: cpm_uart: Remove stale prototype in powerpc/fsl_soc.carch/powerpc/sysdev/fsl_soc.c+0 -20 replies
11/12serial: cpm_uart: Don't include fs_uart_pd.h when not neededarch/powerpc/platforms/8xx/mpc885ads_setup.c arch/powerpc/platforms/8xx/tqm8xx_setup.c drivers/tty/serial/ucc_uart.c+0 -30 replies
12/12serial: cpm_uart: Remove linux/fs_uart_pd.hinclude/linux/fs_uart_pd.h+0 -710 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 00/12] serial: cpm_uart: Cleanup and refactoring

This series is a dust removal and cleanup of cpm_uart serial driver.

After cleaning up things we see that CPM1 and CPM2 have so much in common that it is not worth keeping separate code.

Once refactoring is done, there is only one .c and one .h in cpm_uart/ subdirectory so its worth getting rid of cpm_uart/ subdir.

The last part leads to the complete removal of include/linux/fs_uart_pd.h

Christophe Leroy (12):
serial: cpm_uart: Avoid suspicious locking
serial: cpm_uart: Remove stale prototypes and table and macros
serial: cpm_uart: Stop using fs_uart_id enum
serial: cpm_uart: Use get_baudrate() instead of uart_baudrate()
serial: cpm_uart: Deduplicate cpm_set_{brg/smc_fcr/scc_fcr}()
serial: cpm_uart: Deduplicate cpm_line_cr_cmd()
serial: cpm_uart: Refactor cpm_uart_allocbuf()/cpm_uart_freebuf()
serial: cpm_uart: Refactor cpm_uart_[un]map_pram()
serial: cpm_uart: Remove cpm_uart/ subdirectory
serial: cpm_uart: Remove stale prototype in powerpc/fsl_soc.c
serial: cpm_uart: Don't include fs_uart_pd.h when not needed
serial: cpm_uart: Remove linux/fs_uart_pd.h

 arch/powerpc/include/asm/fs_pd.h              |  10 --
 arch/powerpc/platforms/8xx/mpc885ads_setup.c  |   1 -
 arch/powerpc/platforms/8xx/tqm8xx_setup.c     |   1 -
 arch/powerpc/sysdev/fsl_soc.c                 |   2 -
 drivers/tty/serial/Makefile                   |   2 +-
 .../{cpm_uart/cpm_uart_core.c => cpm_uart.c}  | 157 ++++++++++++++++--
 drivers/tty/serial/{cpm_uart => }/cpm_uart.h  |  38 +----
 drivers/tty/serial/cpm_uart/Makefile          |  12 --
 drivers/tty/serial/cpm_uart/cpm_uart_cpm1.c   | 122 --------------
 drivers/tty/serial/cpm_uart/cpm_uart_cpm1.h   |  33 ----
 drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c   | 156 -----------------
 drivers/tty/serial/cpm_uart/cpm_uart_cpm2.h   |  33 ----
 drivers/tty/serial/ucc_uart.c                 |   1 -
 include/linux/fs_uart_pd.h                    |  71 --------
 14 files changed, 145 insertions(+), 494 deletions(-)
 rename drivers/tty/serial/{cpm_uart/cpm_uart_core.c => cpm_uart.c} (90%)
 rename drivers/tty/serial/{cpm_uart => }/cpm_uart.h (64%)
 delete mode 100644 drivers/tty/serial/cpm_uart/Makefile
 delete mode 100644 drivers/tty/serial/cpm_uart/cpm_uart_cpm1.c
 delete mode 100644 drivers/tty/serial/cpm_uart/cpm_uart_cpm1.h
 delete mode 100644 drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
 delete mode 100644 drivers/tty/serial/cpm_uart/cpm_uart_cpm2.h
 delete mode 100644 include/linux/fs_uart_pd.h
Signature · 1 line
2.41.0