Skip to content

selftests/nolibc: add misc improvments

Zhangjin Wu linux-kselftest lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v13 patches 13 repliesSuperseded

Changes in v2 from the cover letter

* selftests/nolibc: allow report with existing test log tools/nolibc: stackprotector.h: make __stack_chk_init static

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3selftests/nolibc: allow report with existing test logtools/testing/selftests/nolibc/Makefile+4 -00 replies
2/3tools/nolibc: stackprotector.h: make __stack_chk_init statictools/include/nolibc/crt.h tools/include/nolibc/stackprotector.h+3 -40 replies
3/3selftests/nolibc: fix up O= option supporttools/testing/selftests/nolibc/Makefile+9 -65 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchThomas Weißschuh
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] selftests/nolibc: add misc improvments

Hi, Willy, Hi Thomas

Based on Thomas' suggestion, V2 comes here with relative path support for O= option, v1 is [1].

// subdir
$ pwd
/labs/linux-lab/src/linux-stable/tools/testing/selftests/nolibc
$ mkdir -p out
$ make run-user O=out -C /labs/linux-lab/src/linux-stable/tools/testing/selftests/nolibc/ -j4 | grep status Makefile:122: srctree=/labs/linux-lab/src/linux-stable
Makefile:123: objtree: out
Makefile:124: COMMAND_O: O=/labs/linux-lab/src/linux-stable/tools/testing/selftests/nolibc/out Makefile:125: OUTPUT=/labs/linux-lab/src/linux-stable/tools/testing/selftests/nolibc/out/
166 test(s): 158 passed, 8 skipped, 0 failed => status: warning

// topdir
$ pwd
/labs/linux-lab/src/linux-stable
$ mkdir -p out
$ make run-user O=out -C /labs/linux-lab/src/linux-stable/tools/testing/selftests/nolibc/ -j4 | grep status Makefile:122: srctree=/labs/linux-lab/src/linux-stable
Makefile:123: objtree: out
Makefile:124: COMMAND_O: O=/labs/linux-lab/src/linux-stable/out
Makefile:125: OUTPUT=/labs/linux-lab/src/linux-stable/out/
166 test(s): 158 passed, 8 skipped, 0 failed => status: warning

// outside
$ pwd
/labs/linux-lab/build
$ mkdir -p out
$ make run-user O=out -C /labs/linux-lab/src/linux-stable/tools/testing/selftests/nolibc/ -j4 | grep status Makefile:122: srctree=/labs/linux-lab/src/linux-stable
Makefile:123: objtree: out
Makefile:124: COMMAND_O: O=/labs/linux-lab/build/out
Makefile:125: OUTPUT=/labs/linux-lab/build/out/
166 test(s): 158 passed, 8 skipped, 0 failed => status: warning

Changes from v1 --> v2:

* selftests/nolibc: allow report with existing test log tools/nolibc: stackprotector.h: make __stack_chk_init static

Add Reviewed-by line from Thomas

* selftests/nolibc: fix up O= option support

Now with relative path support with the help of $(COMMAND_O).

Suggested by Thomas.

Thanks!
Zhangjin
---
[1]: https://lore.kernel.org/lkml/[email protected]/

Zhangjin Wu (3):
selftests/nolibc: allow report with existing test log tools/nolibc: stackprotector.h: make __stack_chk_init static selftests/nolibc: fix up O= option support

 tools/include/nolibc/crt.h              |  2 +-
 tools/include/nolibc/stackprotector.h   |  5 ++---
 tools/testing/selftests/nolibc/Makefile | 19 +++++++++++++------
 3 files changed, 16 insertions(+), 10 deletions(-)
Signature · 1 line
2.25.1