RFC security: allow a LSM to specify NO-OP return code
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | security: introduce and use call_int_hook_ignore_default()include/ security/ | +36 | 0 replies | |
| 2/3 | security: two more call_int_hook_ignore_default use-casesinclude/ security/ | +6 | 0 replies | |
| 3/3 | security: more call_int_hook_ignore_default use-casesinclude/ security/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RFC 0/3] security: allow a LSM to specify NO-OP return code
This is another attempt to solve the current problem with eBPF LSM, already discussed at least in [1].
The basic idea is to introduce the minimum amount of changes to let the core consider a no-op any LSM hooks returning the LSM_RET_DEFAULT [2].
AFAICS that is already the case for most int hooks with LSM_RET_DEFAULT equal to 0 due to the current call_int_hook implementation. Even most int hook with non zero LSM_RET_DEFAULT are not problematic. Specifically the hooks [3]:
fs_context_parse_paramdentry_init_securityinode_getsecurityinode_setsecurityinode_copy_up_xattrtask_prctlsecurity_secid_to_secctx
already have special handling for to basically ignore default return value from the LSMs, while:
security_getprocattrsecurity_setprocattr
only operate on the specified LSM.
The only hooks that need some love are:
* hooks that have a 0 LSM_RET_DEFAULT, but with no LSM loaded returns a non zero value to the security_<hook> caller:sb_set_mnt_optsinode_init_securityinode_getsecctxsocket_getpeersec_streamsocket_getpeersec_dgram
* hooks that have a 0 LSM_RET_DEFAULT, but internally security_<hook> uses a non zero return value as a selector to perform a default action:inode_setxattrinode_removexattr
* hooks the somehow have to reconciliate multiple, non-zero, LSM return values to take a single decision:vm_enough_memoryxfrm_state_pol_flow_match
This series introduces a new variant of the call_int_hook macro and changes the LSM_RET_DEFAULT for the mentioned hooks, to achieve the goal [2].
The patches have been split according to the above grouping with the hope to simplify the reviews, but I guess could be squashed in a single one.
A simple follow-up would be extend the new hook usage to the hooks [3] to reduce the code duplication.
Sharing as an early RFC (with almost no testing) to try to understand if this path is a no go or instead is somewhat viable.
[1] https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
Paolo Abeni (3):
security: introduce and use call_int_hook_ignore_default()
security: two more call_int_hook_ignore_default use-cases
security: more call_int_hook_ignore_default use-cases
include/linux/lsm_hook_defs.h | 16 +++---- security/security.c | 83 ++++++++++++++++++----------------- 2 files changed, 51 insertions(+), 48 deletions(-)
Signature · 1 line
2.41.0