Skip to content

Add a driver for Epson RX8111 RTC

Waqar Hameed linux-devicetree linux-rtc lkml 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesApplied
  2. v22 patches 5 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

* Remove macro define RX8111_DRV_NAME for the driver name.
* Remove macro function RX8111_TIME_BUF_IDX and instead use the offsets as indices directly.
* Remove rx8111_setup() that disabled extended functionality and interrupts.
* Remove comments explaining register value conversions in rx8111_read/set_time().
* Check/clear register flag XST (oscillation stoppage) in rx8111_read/set_time().
* Change vlval to unsigned int in rx8111_ioctl().
* Remove case RTC_VL_CLR in rx8111_ioctl().
* Convert all dev_err() to dev_dbg().
* Convert all dev_err_probe() to dev_dbg() in probe.
* Return without printing from devm_rtc_register_device() in probe.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: rtc: Add Epson RX8111Documentation/devicetree/bindings/rtc/trivial-rtc.yaml+1 -00 replies
2/2rtc: Add driver for Epson RX8111drivers/rtc/Kconfig drivers/rtc/Makefile drivers/rtc/rtc-rx8111.c+367 -02 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Add a driver for Epson RX8111 RTC

In this patch series we add a basic driver for Epson RX8111 RTC with support for only reading/writing the time and the ioctls RTC_VL_READ and RTC_VL_CLR.

Datasheet: https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en

Changes in v3:
* Remove macro define RX8111_DRV_NAME for the driver name.
* Remove macro function RX8111_TIME_BUF_IDX and instead use the offsets as indices directly.
* Remove rx8111_setup() that disabled extended functionality and interrupts.
* Remove comments explaining register value conversions in rx8111_read/set_time().
* Check/clear register flag XST (oscillation stoppage) in rx8111_read/set_time().
* Change vlval to unsigned int in rx8111_ioctl().
* Remove case RTC_VL_CLR in rx8111_ioctl().
* Convert all dev_err() to dev_dbg().
* Convert all dev_err_probe() to dev_dbg() in probe.
* Return without printing from devm_rtc_register_device() in probe.

Link to v2: https://lore.kernel.org/lkml/[email protected]/

Changes in v2:
* Move dt-bindings to trivial-rtc.yaml.

Link to v1: https://lore.kernel.org/lkml/[email protected]/

Waqar Hameed (2):
dt-bindings: rtc: Add Epson RX8111
rtc: Add driver for Epson RX8111

 .../devicetree/bindings/rtc/trivial-rtc.yaml  |   1 +
 drivers/rtc/Kconfig                           |  10 +
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-rx8111.c                      | 356 ++++++++++++++++++
 4 files changed, 368 insertions(+)
 create mode 100644 drivers/rtc/rtc-rx8111.c

base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263

Signature · 1 line
2.30.2