Skip to content

xen: fix inclusions and static storage duration

Nicola Vetrini xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v16 patches 28 repliesSuperseded

Changes in v2 from the cover letter

- Addressed review comments on the leftover patches
- Patches 1,2,4 from the previous version have already been committed

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3vm_event: rework inclusions to use arch-indipendent headerxen/arch/arm/include/asm/vm_event.h xen/arch/arm/vm_event.c xen/arch/x86/vm_event.c +1 more+3 -31 reply
2/3vpci/msix: make 'get_slot' staticxen/drivers/vpci/msix.c+1 -12 replies
3/3drivers/video: make declarations of defined functions availablexen/arch/x86/include/asm/setup.h xen/arch/x86/platform_hypercall.c xen/arch/x86/pv/dom0_build.c +3 more+18 -184 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchStefano StabelliniRoger Pau Monné
1/3R-b
2/3R-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [XEN PATCH v2 0/3] xen: fix inclusions and static storage duration

The files touched by this series contain function or variable definitions with no prior declaration visible, because it's inside an header that is not included or it's not present anywhere. This is a risk in itself, but also violates MISRA C:2012 Rule 8.4, which states the following:
"A compatible declaration shall be visible when an object or function with external linkage is defined".

The resolution strategies are as follows:

1. make the functions/variables static
2. include the header that contains the compatible declaration

No functional change.

Additional notes:
- This series is a continuation of the work done here [1], so the same additional notes apply.

[1] https://lore.kernel.org/xen-devel/[email protected]/T/#m28da1b5ef8d9a7683937bfc345765e3438b89977

Changes in v2:
- Addressed review comments on the leftover patches
- Patches 1,2,4 from the previous version have already been committed

Nicola Vetrini (3):
vm_event: rework inclusions to use arch-indipendent header vpci/msix: make 'get_slot' static
drivers/video: make declarations of defined functions available

 xen/arch/arm/include/asm/vm_event.h |  1 -
 xen/arch/arm/vm_event.c             |  2 +-
 xen/arch/x86/include/asm/setup.h    |  6 ------
 xen/arch/x86/platform_hypercall.c   |  2 +-
 xen/arch/x86/pv/dom0_build.c        |  2 +-
 xen/arch/x86/vm_event.c             |  2 +-
 xen/drivers/video/vga.c             |  8 --------
 xen/drivers/vpci/msix.c             |  2 +-
 xen/include/xen/console.h           |  2 --
 xen/include/xen/vga.h               | 16 ++++++++++++++++
 xen/include/xen/vm_event.h          |  1 +
 11 files changed, 22 insertions(+), 22 deletions(-)

--
2.34.1