Skip to content

BPF packet scheduler updates part 4

Geliang Tang mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 2 repliesIn review
  2. v2 RFC2 patches 3 repliesSuperseded
  3. v1 RFC11 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- store burst in msk->snd_burst instead of in sk_storage.
- make mptcp_sched_data_set_contexts static.
- rename mptcp_subflow_ctx_by_pos to bpf_mptcp_subflow_ctx_by_pos, and add "__bpf_kfunc" before it.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9Squash to "bpf: Export more bpf_burst related functions"net/mptcp/bpf.c+1 -70 replies
2/9Squash to "mptcp: add sched_data helpers"net/mptcp/bpf.c net/mptcp/protocol.h net/mptcp/sched.c+39 -340 replies
3/9Squash to "bpf: Add bpf_mptcp_sched_ops"net/mptcp/bpf.c+20 -80 replies
4/9Squash to "selftests/bpf: Add mptcp sched structs"tools/testing/selftests/bpf/bpf_tcp_helpers.h+1 -30 replies
5/9Squash to "selftests/bpf: Add bpf_first scheduler"tools/testing/selftests/bpf/progs/mptcp_bpf_first.c+1 -20 replies
6/9Squash to "selftests/bpf: Add bpf_bkup scheduler"tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c+2 -40 replies
7/9Squash to "selftests/bpf: Add bpf_rr scheduler"tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c+4 -50 replies
8/9Squash to "selftests/bpf: Add bpf_red scheduler"tools/testing/selftests/bpf/progs/mptcp_bpf_red.c+2 -40 replies
9/9Squash to "selftests/bpf: Add bpf_burst scheduler"tools/testing/selftests/bpf/bpf_tcp_helpers.h tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c+6 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH mptcp-next v3 0/9] BPF packet scheduler updates part 4

v3:
- store burst in msk->snd_burst instead of in sk_storage.
- make mptcp_sched_data_set_contexts static.
- rename mptcp_subflow_ctx_by_pos to bpf_mptcp_subflow_ctx_by_pos, and add "__bpf_kfunc" before it.

v2:
- keep sched API unchanged.
- use bpf_sk_storage_lookup to get snd_burst from BPF context.
- applied after "add bpf_stale scheduler v3" serise.

v1:

There's a bug in bpf_burst. snd_burst stored in mptcp_burst_storage in BPF context is not used. msk->snd_burst is still used in kernel space. To fix this, add two new interfaces in mptcp_sched_ops to get and set scheduler's paramters from BPF context to kernel space.

Geliang Tang (9):
Squash to "bpf: Export more bpf_burst related functions" Squash to "mptcp: add sched_data helpers" Squash to "bpf: Add bpf_mptcp_sched_ops"
Squash to "selftests/bpf: Add mptcp sched structs" Squash to "selftests/bpf: Add bpf_first scheduler" Squash to "selftests/bpf: Add bpf_bkup scheduler" Squash to "selftests/bpf: Add bpf_rr scheduler" Squash to "selftests/bpf: Add bpf_red scheduler" Squash to "selftests/bpf: Add bpf_burst scheduler"

 net/mptcp/bpf.c                               | 41 +++++++++++----
 net/mptcp/protocol.h                          |  6 +--
 net/mptcp/sched.c                             | 50 ++++++++-----------
 tools/testing/selftests/bpf/bpf_tcp_helpers.h |  5 +-
 .../selftests/bpf/progs/mptcp_bpf_bkup.c      |  6 +--
 .../selftests/bpf/progs/mptcp_bpf_burst.c     | 30 ++---------
 .../selftests/bpf/progs/mptcp_bpf_first.c     |  3 +-
 .../selftests/bpf/progs/mptcp_bpf_red.c       |  6 +--
 .../selftests/bpf/progs/mptcp_bpf_rr.c        |  9 ++--
 9 files changed, 70 insertions(+), 86 deletions(-)
Signature · 1 line
2.35.3