RFC move softmmu options processing from os-posix.c to vl.c
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | include/sysemu/os-posix.h: move *daemonize* declaration togetherinclude/ | +2 | 2 replies | |
| 2/7 | os-posix: create and export os_set_runas()include/ os-posix.c | +17 | 1 reply | |
| 3/7 | os-posix.c: create and export os_set_chroot()include/ os-posix.c | +8 | 1 reply | |
| 4/7 | os-posix.c, softmmu/vl.c: move os_parse_cmd_args() into qemu_init()include/ include/ os-posix.c +1 more | +73 | 1 reply | |
| 5/7 | softmmu/vl.c: inline include/qemu/qemu-options.h into vl.cinclude/ softmmu/ | +10 | 1 reply | |
| 6/7 | os-posix.c: move code aroundos-posix.c | +27 | 1 reply | |
| 7/7 | util/async-teardown.c: move to softmmu/, only build it when system build is requestedsoftmmu/ softmmu/ util/ | +1 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH RFC 0/7] move softmmu options processing from os-posix.c to vl.c
qemu_init() calls os_parse_cmd_args(), which is obviously a very vl.c-specicic piece of code. It looks like when moving vl.c to softmmu/, os-posix.c should've been moved too (together with os-win32.c). But there are other functions in os-posix.c which are used by other parts of the code, eg qemu-nbd or qemu-storage-daemon both uses parts from there. The result is rather ugly. One of the side-effects is that even if system build is disabled, we still have to compile util/async-teardown.c, since it is used in os-posix.c, - and this one can not be built on ia64 due to lack of clone syscall. But qemu-nbd does not need async-teardown, which is also very softmmu-specific.
This patchset tries to address these defects. It moves the "bottom half" of vl.c options processing back into vl.c, effectively undoing commit 59a5264b99434 from 2010. We do not have many os-specific options, and this move makes qemu_init() the only function which processes options, all in the single place, which is, in my opinion, easier to manage.
Before this move, lower-level constructs (chroot, runas) are being exported.
In the end, we have almost no softmmu-related things in os-posix.c, and the same functionality can be actually used in qemu-storage-daemon or qemu-nbd. For qemu-nbd, it is now possible to switch to using -runas/-chroot/etc the same way as qemu-storage-daemon does, instead of having one more abstraction named qemu_daemon().
Michael Tokarev (7):
include/sysemu/os-posix.h: move *daemonize* declaration together
os-posix: create and export os_set_runas()
os-posix.c: create and export os_set_chroot() os-posix.c, softmmu/vl.c: move os_parse_cmd_args() into qemu_init() softmmu/vl.c: inline include/qemu/qemu-options.h into vl.c os-posix.c: move code around
util/async-teardown.c: move to softmmu/, only build it when system
build is requested
include/qemu/qemu-options.h | 41 --------
include/sysemu/os-posix.h | 8 +-
include/sysemu/os-win32.h | 1 -
os-posix.c | 152 +++++++++--------------------
{util => softmmu}/async-teardown.c | 0
softmmu/meson.build | 1 +
softmmu/vl.c | 87 ++++++++++++++++-
util/meson.build | 1 -
8 files changed, 134 insertions(+), 157 deletions(-)
delete mode 100644 include/qemu/qemu-options.h
rename {util => softmmu}/async-teardown.c (100%)Signature · 1 line
2.39.2