Skip to content

btrfs: updates to error path for delayed dir index insertion failure

[email protected] linux-btrfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v12 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: improve error message after failure to add delayed dir index itemfs/btrfs/delayed-inode.c+4 -31 reply
2/3btrfs: remove BUG() after failure to insert delayed dir index itemfs/btrfs/delayed-inode.c+47 -273 replies
3/3btrfs: assert delayed node locked when removing delayed itemfs/btrfs/delayed-inode.c+8 -41 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchQu Wenruo
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] btrfs: updates to error path for delayed dir index insertion failure

From: Filipe Manana <[email protected]>

Some updates to the error path for delayed dir index insertion failure, motivated by a recent syzbot report:

https://lore.kernel.org/linux-btrfs/[email protected]/

Details in the changelogs.

v2: Fixed error path in patch 2 to release delayed item before unlocking
the delayed node. Added patch 3 to prevent such mistakes in the future.

Filipe Manana (3):
btrfs: improve error message after failure to add delayed dir index item
btrfs: remove BUG() after failure to insert delayed dir index item
btrfs: assert delayed node locked when removing delayed item

 fs/btrfs/delayed-inode.c | 85 ++++++++++++++++++++++++++--------------
 1 file changed, 55 insertions(+), 30 deletions(-)
Signature · 1 line
2.40.1