Skip to content

add rpc_status netlink support for NFSD

Lorenzo Bianconi linux-nfs netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest3 patches 24 repliesIn review
  2. v73 patches 2 repliesSuperseded

Changes in v8 from the cover letter

- introduce nfsd_server.yaml for netlink messages

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Documentation: netlink: add a YAML spec for nfsd_serverDocumentation/netlink/specs/nfsd_server.yaml+97 -08 replies
2/3NFSD: introduce netlink rpc_status stubsfs/nfsd/Makefile fs/nfsd/nfs_netlink_gen.c fs/nfsd/nfs_netlink_gen.h +2 more+121 -15 replies
3/3NFSD: add rpc_status netlink supportfs/nfsd/nfsctl.c fs/nfsd/nfsd.h fs/nfsd/nfssvc.c +2 more+222 -49 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJeff Layton
1/3T-b A-b
2/3T-b A-b
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/3] add rpc_status netlink support for NFSD

Introduce rpc_status netlink support for NFSD in order to dump pending RPC requests debugging information from userspace.
The new code can be tested with the user-space tool reported below:
https://github.com/LorenzoBianconi/nfsd-rpc-netlink-monitor/tree/main

Changes since v7:
- introduce nfsd_server.yaml for netlink messages

Changes since v6:
- report info to user-space through netlink and get rid of the related entry in the procfs

Changes since v5:
- add missing delimiters for nfs4 compound ops
- add a header line for rpc_status handler
- do not dump rq_prog
- do not dump rq_flags in hex

Changes since v4:
- rely on acquire/release APIs and get rid of atomic operation
- fix kdoc for nfsd_rpc_status_open
- get rid of ',' as field delimiter in nfsd_rpc_status hanlder
- move nfsd_rpc_status before nfsd_v4 enum entries
- fix compilantion error if nfsdv4 is not enabled

Changes since v3:
- introduce rq_status_counter in order to detect if the RPC request is pending and RPC info are stable
- rely on __svc_print_addr to dump IP info

Changes since v2:
- minor changes in nfsd_rpc_status_show output

Changes since v1:
- rework nfsd_rpc_status_show output

Changes since RFCv1:
- riduce time holding nfsd_mutex bumping svc_serv refcoung in nfsd_rpc_status_open()
- dump rqstp->rq_stime
- add missing kdoc for nfsd_rpc_status_open()

Lorenzo Bianconi (3):
Documentation: netlink: add a YAML spec for nfsd_server
NFSD: introduce netlink rpc_status stubs
NFSD: add rpc_status netlink support

 Documentation/netlink/specs/nfsd_server.yaml |  97 +++++++++
 fs/nfsd/Makefile                             |   3 +-
 fs/nfsd/nfs_netlink_gen.c                    |  32 +++
 fs/nfsd/nfs_netlink_gen.h                    |  22 ++
 fs/nfsd/nfsctl.c                             | 204 +++++++++++++++++++
 fs/nfsd/nfsd.h                               |  16 ++
 fs/nfsd/nfssvc.c                             |  15 ++
 fs/nfsd/state.h                              |   2 -
 include/linux/sunrpc/svc.h                   |   1 +
 include/uapi/linux/nfsd_server.h             |  49 +++++
 10 files changed, 438 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/netlink/specs/nfsd_server.yaml
 create mode 100644 fs/nfsd/nfs_netlink_gen.c
 create mode 100644 fs/nfsd/nfs_netlink_gen.h
 create mode 100644 include/uapi/linux/nfsd_server.h
Signature · 1 line
2.41.0