Skip to content

Improve test coverage of TTM

Karolina Stolarek dri-devel 15 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v14 Latest12 patches 3 repliesIn review
  2. v1312 patches 3 repliesSuperseded
  3. v1210 patches 9 repliesSuperseded
Earlier versions · 12
VersionPostedPatchesRepliesStatus
v1110 patches4 repliesSuperseded
v109 patches15 repliesSuperseded
v9 posting 2/28 patches3 repliesSuperseded
v9 posting 1/28 patches0 repliesSuperseded
v88 patches8 repliesSuperseded
v78 patches10 repliesSuperseded
v68 patches3 repliesSuperseded
v54 patches11 repliesSuperseded
v44 patches0 repliesSuperseded
v34 patches5 repliesSuperseded
v25 patches7 repliesSuperseded
v13 patches5 repliesSuperseded

Changes in v14 from the cover letter

- Merge checks for system <-> TT move into one (Thomas)

Patches in v14 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulkdrivers/gpu/drm/ttm/tests/ttm_bo_test.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h +3 more+45 -310 replies
2/12drm/ttm/tests: Delete unnecessary config optiondrivers/gpu/drm/ttm/tests/.kunitconfig+0 -10 replies
3/12drm/ttm/tests: Set DMA mask in KUnit devicedrivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c+3 -00 replies
4/12drm/ttm/tests: Use an init function from the helpers libdrivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h drivers/gpu/drm/ttm/tests/ttm_tt_test.c+16 -140 replies
5/12drm/ttm/tests: Test simple BO creation and validationdrivers/gpu/drm/ttm/tests/Makefile drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +1 more+228 -10 replies
6/12drm/ttm/tests: Add tests with mock resource managersdrivers/gpu/drm/Kconfig drivers/gpu/drm/ttm/tests/Makefile drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c +3 more+535 -20 replies
7/12drm/ttm/tests: Add test cases dependent on fence signalingdrivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c+305 -00 replies
8/12drm/ttm/tests: Add eviction testingdrivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h +2 more+568 -90 replies
9/12drm/ttm/tests: Add tests for ttm_tt_populatedrivers/gpu/drm/ttm/tests/ttm_tt_test.c drivers/gpu/drm/ttm/ttm_tt.c+122 -00 replies
10/12drm/ttm/tests: Add TODO filedrivers/gpu/drm/ttm/tests/TODO+27 -00 replies
11/12drm/ttm/tests: Correct modules' licensesdrivers/gpu/drm/ttm/tests/ttm_bo_test.c drivers/gpu/drm/ttm/tests/ttm_device_test.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +3 more+6 -60 replies
12/12drm/ttm/tests: Use u32 and u64 over uint*_t typesdrivers/gpu/drm/ttm/tests/ttm_bo_test.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h +3 more+25 -270 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchThomas HellströmNirmoy DasMatthew AuldSomalapuram, Amaranath
1/12R-b
2/12R-b
3/12R-b
4/12R-b R-b
5/12R-b R-b T-b
6/12R-b T-b
7/12R-b T-b
8/12R-b T-b
9/12R-b T-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v14 thread

Cover letter [PATCH v14 00/12] Improve test coverage of TTM

Introduce tests for ttm_bo_validate()/ttm_bo_init_validate() that exercise simple BO placement as well as eviction (including the case where the evict domain also requires eviction to fit the incoming buffer). Prepare KUnit helpers to handle such scenarios and add a mock VRAM manager. This series also includes some updates to the helpers and more definitions used to define "special" memory domains (e.g., one that can't allocate resources or is busy), as well as drive-by fixes for the tests.

There are a couple of areas in which this test suite can be improved. Suggestions for future work can be found in the TODO file.

Use kunit_tool script to manually run all the tests:

$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/ttm/tests

To build a kernel with TTM KUnit tests, use a UML configuration, enable CONFIG_KUNIT, and then select CONFIG_DRM_TTM_KUNIT_TEST.

Many thanks,
Karolina

v14:
- Merge checks for system <-> TT move into one (Thomas)

v13 (all suggestions by Thomas):
- Drop CONFIG_DRM_BUDDY=y from .kunitconfig
- Remove ttm_bo_wait_ctx(bo, ctx) call from the mock move, it's not needed
- Update MODULE_LICENSE descriptions (also respectively, 11/12)
- Use u32 and u64 types instead uint(32|64)_t (also respectively, 12/12)
- Update TODO to describe how the mock manager can be rewritten

v12:
- Rewrite "drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk" patch to extend ttm_bo_kunit_init() helper to accept a dma_resv object and update calls to that helper (Christian)
- Update drm_buddy_free_list() calls with an extra argument

Karolina Stolarek (12):
drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk drm/ttm/tests: Delete unnecessary config option drm/ttm/tests: Set DMA mask in KUnit device drm/ttm/tests: Use an init function from the helpers lib drm/ttm/tests: Test simple BO creation and validation drm/ttm/tests: Add tests with mock resource managers drm/ttm/tests: Add test cases dependent on fence signaling drm/ttm/tests: Add eviction testing drm/ttm/tests: Add tests for ttm_tt_populate drm/ttm/tests: Add TODO file
drm/ttm/tests: Correct modules' licenses drm/ttm/tests: Use u32 and u64 over uint*_t types

 drivers/gpu/drm/Kconfig                       |    1 +
 drivers/gpu/drm/ttm/tests/.kunitconfig        |    1 -
 drivers/gpu/drm/ttm/tests/Makefile            |    2 +
 drivers/gpu/drm/ttm/tests/TODO                |   27 +
 drivers/gpu/drm/ttm/tests/ttm_bo_test.c       |   54 +-
 .../gpu/drm/ttm/tests/ttm_bo_validate_test.c  | 1224 +++++++++++++++++
 drivers/gpu/drm/ttm/tests/ttm_device_test.c   |    2 +-
 drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c |  175 ++-
 drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h |   17 +-
 drivers/gpu/drm/ttm/tests/ttm_mock_manager.c  |  233 ++++
 drivers/gpu/drm/ttm/tests/ttm_mock_manager.h  |   30 +
 drivers/gpu/drm/ttm/tests/ttm_pool_test.c     |    8 +-
 drivers/gpu/drm/ttm/tests/ttm_resource_test.c |   20 +-
 drivers/gpu/drm/ttm/tests/ttm_tt_test.c       |  168 ++-
 drivers/gpu/drm/ttm/ttm_tt.c                  |    3 +
 15 files changed, 1877 insertions(+), 88 deletions(-)
 create mode 100644 drivers/gpu/drm/ttm/tests/TODO
 create mode 100644 drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
 create mode 100644 drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
 create mode 100644 drivers/gpu/drm/ttm/tests/ttm_mock_manager.h
Signature · 1 line
2.34.1