Skip to content

drm/tegra: Fix some error handling paths

Christophe JAILLET dri-devel kernel-janitors linux-tegra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/tegra: dsi: Fix some error handling paths in tegra_dsi_probe()drivers/gpu/drm/tegra/dsi.c+35 -190 replies
2/6drm/tegra: dsi: Fix missing pm_runtime_disable() in the error handling path of tegra_dsi_probe()drivers/gpu/drm/tegra/dsi.c+1 -00 replies
3/6drm/tegra: hdmi: Fix some error handling paths in tegra_hdmi_probe()drivers/gpu/drm/tegra/hdmi.c+13 -70 replies
4/6drm/tegra: rgb: Fix some error handling paths in tegra_dc_rgb_probe()drivers/gpu/drm/tegra/rgb.c+11 -50 replies
5/6drm/tegra: rgb: Fix missing clk_put() in the error handling paths of tegra_dc_rgb_probe()drivers/gpu/drm/tegra/rgb.c+3 -10 replies
6/6drm/tegra: output: Fix missing i2c_put_adapter() in the error handling paths of tegra_output_probe()drivers/gpu/drm/tegra/output.c+12 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] drm/tegra: Fix some error handling paths

Most of the patches are retated to tegra_output_probe() and missing tegra_output_remove(). Others are things spotted while writting the serie.

Patches 1, 3, 4 are verbose, but some functions called in the probe can return -EPROBE_DEFER, so it is nice to correctly release resources.

Maybe moving the tegra_output_probe() call would minimize the changes, but I'm always reluctant to move code, because of possible side-effects.

Christophe JAILLET (6):
drm/tegra: dsi: Fix some error handling paths in tegra_dsi_probe() drm/tegra: dsi: Fix missing pm_runtime_disable() in the error handling
path of tegra_dsi_probe()
drm/tegra: dsi: Fix some error handling paths in tegra_hdmi_probe() drm/tegra: rgb: Fix some error handling paths in tegra_dc_rgb_probe() drm/tegra: rgb: Fix missing clk_put() in the error handling paths of
tegra_dc_rgb_probe()
drm/tegra: output: Fix missing i2c_put_adapter() in the error handling
paths of tegra_output_probe()

 drivers/gpu/drm/tegra/dsi.c    | 55 ++++++++++++++++++++++------------
 drivers/gpu/drm/tegra/hdmi.c   | 20 ++++++++-----
 drivers/gpu/drm/tegra/output.c | 16 +++++++---
 drivers/gpu/drm/tegra/rgb.c    | 18 +++++++----
 4 files changed, 74 insertions(+), 35 deletions(-)
Signature · 1 line
2.34.1