Skip to content

NFSv4 READDIR d_type fixup

Benjamin Coddington linux-nfs 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 posting 2/21 patch 1 replyIn review
  2. v3 Latest2 patches 0 repliesNew
  3. v22 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 posting 1/22 patches9 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2NFSv4: Always ask for type with READDIRfs/nfs/nfs4xdr.c+2 -20 replies
2/2NFSv4: Allow per-mount tuning of READDIR attrsfs/nfs/Kconfig fs/nfs/client.c fs/nfs/nfs4client.c +5 more+112 -40 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJeff Layton
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] NFSv4 READDIR d_type fixup

This is a combined posting of two previously posted patches. The first unconditionally adds the type attribute to the list of requested attributes for v4 READDIR. The second patch enables a per-mount modification via sysfs of any of the attributes the client will currently decode for v4 READDIR.

The first patch solves a real problem but may cause a performance regression for some servers that require extra processing to return inode information along with the namespace. We performed an informal survey of most of the major NFSv4 server vendors and although we did not learn of any that may be impacted, the potential remains.

The second patch gives us a way to disable this new READDIR behavior should we find a serious impact in an existing setup. I would appreciate serious consideration of this patch in light of the number of claimed performance regressions that have been reported almost every time we touch this sensitive operation on the client.

For example:

echo 0x800 0x800000 0x0 > /sys/fs/nfs/0\:57/v4_readdir_attrs

.. will revert the behavior change from patch 1.

Changes on v2:
- fix patch 2/2 to compile without CONFIG_NFS_4

Changes on v3:
- fix a lkp warning about line spacing
- hide the v4_readdir_attrs behind CONFIG_NFS_EXPERT_SYSFS

Benjamin Coddington (2):
NFSv4: Always ask for type with READDIR
NFSv4: Allow per-mount tuning of READDIR attrs

 fs/nfs/Kconfig            |  7 +++
 fs/nfs/client.c           |  4 ++
 fs/nfs/nfs4client.c       |  4 ++
 fs/nfs/nfs4proc.c         |  1 +
 fs/nfs/nfs4xdr.c          |  9 ++--
 fs/nfs/sysfs.c            | 91 +++++++++++++++++++++++++++++++++++++++
 include/linux/nfs_fs_sb.h |  1 +
 include/linux/nfs_xdr.h   |  1 +
 8 files changed, 113 insertions(+), 5 deletions(-)
Signature · 1 line
2.41.0