btrfs-progs: follow-ups for issue #622
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs-progs: dump-tree: output the sequence number for inline referenceskernel-shared/ | +19 | 0 replies | |
| 2/3 | btrfs-progs: check/lowmem: verify the sequence of inline backref itemscheck/ check/ | +32 | 0 replies | |
| 3/3 | btrfs-progs: fsck-tests: add test image of out-of-order inline backref itemstests/ tests/ | +19 | 3 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Anand Jain |
|---|---|
| Series | R-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] btrfs-progs: follow-ups for issue #622
Issue #622 is a very interesting bug report, that ntfs2btrfs has a fixed bug that it can generate out-of-order inline backref items.
This leads to kernel transaction abort, but btrfs-check failed to detect it at all.
Although the fix for btrfs-progs is already merged in the latest v6.5.3 release, we still lacks the following thing:
- Better dump-tree support to show the weird inline backref order This is very weird, as we have the inline type in ascending order, but for the sequence number (hash for EXTENT_DATA_REF, offset for all other types) it is descending inside the same type.
That's why the following output of one data extent item looks out-of-order:
item 0 key (13631488 EXTENT_ITEM 4096) itemoff 16143 itemsize 140
refs 4 gen 7 flags DATA
extent data backref root FS_TREE objectid 258 offset 0 count 1 extent data backref root FS_TREE objectid 257 offset 0 count 1 extent data backref root FS_TREE objectid 260 offset 0 count 1 extent data backref root FS_TREE objectid 259 offset 0 count 1
- Lowmem mode support to detect the error
- Test case to make sure we can detect the error
This series would address all the three points above.
Qu Wenruo (3):
btrfs-progs: dump-tree: output the sequence number for inline
references
btrfs-progs: check/lowmem: verify the sequence of inline backref items
btrfs-progs: fsck-tests: add test image of out-of-order inline backref
items
check/mode-lowmem.c | 31 ++++++++++++++++++ check/mode-lowmem.h | 1 + kernel-shared/print-tree.c | 31 +++++++++++------- .../btrfs_image.xz | Bin 0 -> 2264 bytes .../061-out-of-order-inline-backref/test.sh | 19 +++++++++++ 5 files changed, 70 insertions(+), 12 deletions(-) create mode 100644 tests/fsck-tests/061-out-of-order-inline-backref/btrfs_image.xz create mode 100755 tests/fsck-tests/061-out-of-order-inline-backref/test.sh
--
2.42.0