Skip to content

i2c: add zhaoxin i2c controller driver

Hans Hu linux-i2c oe-kbuild-all 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest6 patches 5 repliesIn review
  2. v86 patches 7 repliesSuperseded
  3. v76 patches 15 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v68 patches20 repliesSuperseded
v58 patches0 repliesSuperseded
v48 patches2 repliesSuperseded
v312 patches11 repliesApplied

Changes in v10 from the cover letter

* fixed style issues that were checked out by checkpatch.pl.
* In Patch 3 in wmt_i2c_write() function, deleted the log when received nack.
* In Patch 4 in viai2c_irq_xfer() function, return 1 for I2C_SMBUS_QUICK access.
* In Patch 6 in zxi2c_get_bus_speed() function, adjusted the log when firmware gives inappropriate parameters.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6i2c: wmt: create wmt_i2c_init for general initdrivers/i2c/busses/i2c-wmt.c+37 -281 reply
2/6i2c: wmt: split out common filesMAINTAINERS drivers/i2c/busses/Makefile drivers/i2c/busses/i2c-viai2c-common.c +3 more+442 -4310 replies
3/6i2c: wmt: rename somethingdrivers/i2c/busses/i2c-viai2c-common.c drivers/i2c/busses/i2c-viai2c-common.h drivers/i2c/busses/i2c-viai2c-wmt.c+143 -1461 reply
4/6i2c: wmt: fix a bug when thread blockeddrivers/i2c/busses/i2c-viai2c-common.c drivers/i2c/busses/i2c-viai2c-common.h+80 -710 replies
5/6i2c: wmt: add platform type VIAI2C_PLAT_WMTdrivers/i2c/busses/i2c-viai2c-common.c drivers/i2c/busses/i2c-viai2c-common.h drivers/i2c/busses/i2c-viai2c-wmt.c+27 -140 replies
6/6i2c: add zhaoxin i2c controller driverMAINTAINERS drivers/i2c/busses/Kconfig drivers/i2c/busses/Makefile +3 more+353 -50 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchWolfram SangAndi Shyti
1/6R-b R-b
2/6R-b
3/6R-b
4/6R-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 0/6] i2c: add zhaoxin i2c controller driver

v9->v10:
* fixed style issues that were checked out by checkpatch.pl.
* In Patch 3 in wmt_i2c_write() function, deleted the log when received nack.
* In Patch 4 in viai2c_irq_xfer() function, return 1 for I2C_SMBUS_QUICK access.
* In Patch 6 in zxi2c_get_bus_speed() function, adjusted the log when firmware gives inappropriate parameters.

v8->v9:
* In Patch 1 in probe() do not return at the i2c_add_adapter(), but call clk_disable_unprepare() in case of failure.
* In Patch 2 fix the conflict when i2c-wmt.c is removed.
* In Patch 2 in wmt_i2c_probe() function, call clk_disable_unprepare() in case of failure. While at it, add a comment to explain the reason.
* When renaming i2c_dev to i2c, change also the reference in clk_disable_unprepare().

v7->v8:
* move per-msg handling to interrupt context
* add private struct viai2c_zhaoxin to handle zhaoxin specific things
* fixed some other formatting issues

v6->v7:
* adjust the patch sequence
* put those renaming related patches in 1 patch file
* rename i2c-*-plt.c to i2c-viai2c-*.c
* Some other adjustments suggested by Andi For more details, see the comment in each patch please.

v5->v6:

	* fix build warnning reported by kernel test robot.
	  Link: https://lore.kernel.org/all/[email protected]/
	Link: https://lore.kernel.org/all/[email protected]/

v4->v5:

	* fix 1 build error.
	  Link: https://lore.kernel.org/all/ZYx0VPVmyQhtG+B9@shikoro/1-a.txt
	Link: https://lore.kernel.org/all/[email protected]/

v3->v4:
* Some adjustments as suggested by Wolfram.
* rebase patch on top of for-next branch.

v2->v3:

	* Split the number of patches from 2 to 12. Make it easier to review.
	Link: https://lore.kernel.org/all/[email protected]/

v1->v2:

	* Fixed some bugs I found myself.
	Link: https://lore.kernel.org/all/[email protected]/

Old version:
This patch has already gone through a round of reviews. The difference from the first round is that it reuses the i2c-wmt driver.

Hans Hu (6):
i2c: wmt: create wmt_i2c_init for general init
i2c: wmt: split out common files
i2c: wmt: rename something
i2c: wmt: fix a bug when thread blocked
i2c: wmt: add platform type VIAI2C_PLAT_WMT
i2c: add zhaoxin i2c controller driver

 MAINTAINERS                             |  10 +-
 drivers/i2c/busses/Kconfig              |  10 +
 drivers/i2c/busses/Makefile             |   3 +
 drivers/i2c/busses/i2c-viai2c-common.c  | 256 ++++++++++++++
 drivers/i2c/busses/i2c-viai2c-common.h  |  85 +++++
 drivers/i2c/busses/i2c-viai2c-wmt.c     | 148 +++++++++
 drivers/i2c/busses/i2c-viai2c-zhaoxin.c | 298 +++++++++++++++++
 drivers/i2c/busses/i2c-wmt.c            | 421 ------------------------
 8 files changed, 809 insertions(+), 422 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-viai2c-common.c
 create mode 100644 drivers/i2c/busses/i2c-viai2c-common.h
 create mode 100644 drivers/i2c/busses/i2c-viai2c-wmt.c
 create mode 100644 drivers/i2c/busses/i2c-viai2c-zhaoxin.c
 delete mode 100644 drivers/i2c/busses/i2c-wmt.c
Signature · 1 line
2.34.1