Skip to content

RFC kasan: save mempool stack traces

[email protected] linux-mm lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest20 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20kasan: rename kasan_slab_free_mempool to kasan_mempool_poison_objectinclude/linux/kasan.h io_uring/alloc_cache.h mm/kasan/common.c +1 more+8 -90 replies
2/20kasan: move kasan_mempool_poison_objectinclude/linux/kasan.h mm/kasan/common.c+31 -310 replies
3/20kasan: document kasan_mempool_poison_objectinclude/linux/kasan.h+18 -00 replies
4/20kasan: add return value for kasan_mempool_poison_objectinclude/linux/kasan.h mm/kasan/common.c+22 -160 replies
5/20kasan: introduce kasan_mempool_unpoison_objectinclude/linux/kasan.h mm/kasan/common.c+36 -00 replies
6/20kasan: introduce kasan_mempool_poison_pagesinclude/linux/kasan.h mm/kasan/common.c+50 -00 replies
7/20kasan: introduce kasan_mempool_unpoison_pagesinclude/linux/kasan.h mm/kasan/common.c+31 -00 replies
8/20kasan: clean up __kasan_mempool_poison_objectmm/kasan/common.c+7 -120 replies
9/20kasan: save free stack traces for slab mempoolsinclude/linux/kasan.h mm/kasan/common.c+12 -130 replies
10/20kasan: clean up and rename ____kasan_kmallocmm/kasan/common.c+22 -200 replies
11/20kasan: introduce poison_kmalloc_large_redzonemm/kasan/common.c+23 -180 replies
12/20kasan: save alloc stack traces for mempoolinclude/linux/kasan.h mm/kasan/common.c+44 -130 replies
13/20mempool: use new mempool KASAN hooksmm/mempool.c+12 -100 replies
14/20mempool: introduce mempool_use_prealloc_onlyinclude/linux/mempool.h mm/mempool.c+26 -33 replies
15/20kasan: add mempool testsmm/kasan/kasan_test.c+325 -00 replies
16/20kasan: rename pagealloc testsmm/kasan/kasan_test.c+26 -250 replies
17/20kasan: reorder testsmm/kasan/kasan_test.c+209 -2090 replies
18/20kasan: rename and document kasan_(un)poison_object_datainclude/linux/kasan.h mm/kasan/common.c mm/slab.c +2 more+39 -220 replies
19/20skbuff: use mempool KASAN hooksnet/core/skbuff.c+6 -40 replies
20/20io_uring: use mempool KASAN hookio_uring/alloc_cache.h+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 00/20] kasan: save mempool stack traces

From: Andrey Konovalov <[email protected]>

This series updates KASAN to save alloc and free stack traces for secondary-level allocators that cache and reuse allocations internally instead of giving them back to the underlying allocator (e.g. mempool).

As a part of this change, introduce and document a set of KASAN hooks:

bool kasan_mempool_poison_pages(struct page *page, unsigned int order); void kasan_mempool_unpoison_pages(struct page *page, unsigned int order); bool kasan_mempool_poison_object(void *ptr);
void kasan_mempool_unpoison_object(void *ptr, size_t size);

and use them in the mempool code.

Besides mempool, skbuff and io_uring also cache allocations and already use KASAN hooks to poison those. Their code is updated to use the new mempool hooks.

The new hooks save alloc and free stack traces (for normal kmalloc and slab objects; stack traces for large kmalloc objects and page_alloc are not supported by KASAN yet), improve the readability of the users' code, and also allow the users to prevent double-free and invalid-free bugs; see the patches for the details.

I'm posting this series as an RFC, as it has a few non-trivial-to-resolve conflicts with the stack depot eviction patches. I'll rebase the series and resolve the conflicts once the stack depot patches are in the mm tree.

Andrey Konovalov (20):
kasan: rename kasan_slab_free_mempool to kasan_mempool_poison_object
kasan: move kasan_mempool_poison_object
kasan: document kasan_mempool_poison_object
kasan: add return value for kasan_mempool_poison_object
kasan: introduce kasan_mempool_unpoison_object
kasan: introduce kasan_mempool_poison_pages
kasan: introduce kasan_mempool_unpoison_pages
kasan: clean up __kasan_mempool_poison_object
kasan: save free stack traces for slab mempools
kasan: clean up and rename ____kasan_kmalloc
kasan: introduce poison_kmalloc_large_redzone
kasan: save alloc stack traces for mempool
mempool: use new mempool KASAN hooks
mempool: introduce mempool_use_prealloc_only
kasan: add mempool tests
kasan: rename pagealloc tests
kasan: reorder tests
kasan: rename and document kasan_(un)poison_object_data
skbuff: use mempool KASAN hooks
io_uring: use mempool KASAN hook

 include/linux/kasan.h   | 161 +++++++-
 include/linux/mempool.h |   2 +
 io_uring/alloc_cache.h  |   5 +-
 mm/kasan/common.c       | 221 ++++++----
 mm/kasan/kasan_test.c   | 876 +++++++++++++++++++++++++++-------------
 mm/mempool.c            |  49 ++-
 mm/slab.c               |  10 +-
 mm/slub.c               |   4 +-
 net/core/skbuff.c       |  10 +-
 9 files changed, 940 insertions(+), 398 deletions(-)
Signature · 1 line
2.25.1