Skip to content

revision: exclude all packed objects with `--unpacked`

Taylor Blau git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2list-objects: drop --unpacked non-commit objects from resultslist-objects.c t/t6000-rev-list-misc.sh+16 -02 replies
2/2pack-bitmap: drop --unpacked non-commit objects from resultspack-bitmap.c t/t6113-rev-list-bitmap-filters.sh t/t6115-rev-list-du.sh+47 -02 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJeff King
1/2Co-authored-by
2/2Co-authored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] revision: exclude all packed objects with `--unpacked`

While working on my longer series to enable verbatim pack reuse across multiple packs[^1], I noticed a couple of oddities with the --unpacked rev-walk flag.

While it does exclude packed commits, it does not exclude (all) packed trees/blobs/annotated tags. This problem exists in the pack-bitmap machinery, too, which will over-count queries like:

    $ git rev-list --use-bitmap-index --all --unpacked --objects

, etc.

The fix is relatively straightforward, split across two patches that Peff and I worked on together earlier today.

This is technically a backwards-incompatible change, but the existing behavior is broken and does not match the documented behavior, so I think in this case we are OK to change --unpacked to faithfully implement its documentation.

[^1]: Which, I'm very excited to say, is working :-).

Taylor Blau (2):
list-objects: drop --unpacked non-commit objects from results
pack-bitmap: drop --unpacked non-commit objects from results

 list-objects.c                     |  3 +++
 pack-bitmap.c                      | 27 +++++++++++++++++++++++++++
 t/t6000-rev-list-misc.sh           | 13 +++++++++++++
 t/t6113-rev-list-bitmap-filters.sh | 13 +++++++++++++
 t/t6115-rev-list-du.sh             |  7 +++++++
 5 files changed, 63 insertions(+)

base-commit: bc5204569f7db44d22477485afd52ea410d83743

Signature · 1 line
2.43.0.rc0.2.gef6b2154a3