Skip to content

dump for userspace pm

Geliang Tang llvm mptcp oe-kbuild-all 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest23 patches 2 repliesIn review
  2. v823 patches 2 repliesSuperseded
  3. v724 patches 12 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v624 patches1 replySuperseded
v514 patches0 repliesSuperseded
v414 patches2 repliesSuperseded
v314 patches6 repliesSuperseded
v215 patches1 replySuperseded
v112 patches3 repliesSuperseded

Changes in v9 from the cover letter

- add missing "sock_put(sk)" in patch 7, 17 and 21 to fix the "kmemleak" errors reported by CI.
- rename the helper to mptcp_pm_has_addr_attr_id.
- use my new mail address.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23mptcp: add pm_has_addr_attr_id helpernet/mptcp/pm.c net/mptcp/protocol.h+14 -00 replies
2/23mptcp: add needs_id for userspace appending addrnet/mptcp/pm_userspace.c+9 -60 replies
3/23mptcp: add needs_id for netlink appending addrnet/mptcp/pm_netlink.c+7 -50 replies
4/23mptcp: map v4 address to v6 when destroying subflownet/mptcp/pm_userspace.c+10 -00 replies
5/23selftests: mptcp: rm subflow with v4/v4mapped addrtools/testing/selftests/net/mptcp/mptcp_join.sh+8 -30 replies
6/23mptcp: export mptcp_genl_family & mptcp_nl_fill_addrnet/mptcp/pm_netlink.c net/mptcp/protocol.h+7 -60 replies
7/23mptcp: implement mptcp_userspace_pm_dump_addrnet/mptcp/pm_userspace.c net/mptcp/protocol.h+62 -00 replies
8/23mptcp: add token for get-addr in yamlDocumentation/netlink/specs/mptcp_pm.yaml net/mptcp/mptcp_pm_gen.c net/mptcp/mptcp_pm_gen.h+7 -50 replies
9/23mptcp: dump addrs in userspace pm listnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.h+20 -20 replies
10/23mptcp: check userspace pm subflow flagnet/mptcp/pm_userspace.c+8 -20 replies
11/23selftests: mptcp: add userspace pm subflow flagtools/testing/selftests/net/mptcp/pm_nl_ctl.c+8 -00 replies
12/23selftests: mptcp: add token for dump_addrtools/testing/selftests/net/mptcp/pm_nl_ctl.c+17 -00 replies
13/23selftests: mptcp: add check_output helpertools/testing/selftests/net/mptcp/mptcp_join.sh+27 -00 replies
14/23selftests: mptcp: dump after creating id 0 subflowtools/testing/selftests/net/mptcp/mptcp_join.sh+15 -00 replies
15/23selftests: mptcp: dump userspace addrs listtools/testing/selftests/net/mptcp/mptcp_join.sh+44 -00 replies
16/23mptcp: add userspace_pm_lookup_addr_by_id helpernet/mptcp/pm_userspace.c+16 -150 replies
17/23mptcp: implement mptcp_userspace_pm_get_addrnet/mptcp/pm_userspace.c net/mptcp/protocol.h+76 -00 replies
18/23mptcp: get addr in userspace pm listnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.h+15 -10 replies
19/23selftests: mptcp: add token for get_addrtools/testing/selftests/net/mptcp/pm_nl_ctl.c+13 -10 replies
20/23selftests: mptcp: userspace pm get addr teststools/testing/selftests/net/mptcp/mptcp_join.sh+16 -00 replies
21/23mptcp: update set_flags interfacesnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+58 -520 replies
22/23mptcp: set error messages for set_flagsnet/mptcp/pm_netlink.c net/mptcp/pm_userspace.c+12 -30 replies
23/23selftests: mptcp: flush userspace addrs listtools/testing/selftests/net/mptcp/mptcp_join.sh+41 -42 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.

Read the v9 thread

Cover letter [PATCH mptcp-next v9 00/23] dump for userspace pm

From: Geliang Tang <[email protected]>

v9:
- add missing "sock_put(sk)" in patch 7, 17 and 21 to fix the "kmemleak" errors reported by CI.
- rename the helper to mptcp_pm_has_addr_attr_id.
- use my new mail address.

v8:
- Address Mat's comments in v7

v7:
- fix checkpatch.sh warning reported by CI.
- fix build errors reported by CI.

v6:
- patches 1-5, fixes for -net
- patches 6, 15, selftests for "fixes for -net".
- patches 7-14, 16-21, update "dump for userspace pm v5"
- patches 22, 23, cleanups for set_flags
- patch 24, flush selftest.

v5:
- patch 2, save bitmap instead of id.
- patch 3, drop token in reply.
- update patch 4 and patch 12, add mptcp_pm_dump_addr and mptcp_pm_get_addr wrappers in pm.c

v4:
- update patch 2, patch 3 and patch 12.
- fix the warnings reported by CI in v3:

Unable to validate one commit: 7633a101a mptcp: get addr in userspace pm list
Unable to compile mptcp source code with make W=1 net/mptcp/pm_netlink.o
Unable to compile mptcp source code with make C=1 net/mptcp/pm_netlink.o: net/mptcp/pm_netlink.c:1656:5: warning: symbol 'mptcp_pm_nl_get_addr' was not declared. Should it be static?

v3:
- fix the errors reported by CI in v2:

[10:55:51.288] [  897.523894][ T5664] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:306
[10:55:51.288] [  897.532157][ T5664] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 5664, name: pm_nl_ctl
[10:55:51.289] [  897.539503][ T5664] preempt_count: 201, expected: 0

- drop mptcp_pm_nl_put_entry_msg and mptcp_pm_nl_put_entry_info helpers.

v2:
Address Mat's comments in v1:
- patch 2: pass token to dump_addr too.
- patch 2: add back id in mptcp_userspace_pm_dump_addr().
- patch 5: update mptcp.yaml

v1:
Address Mat's comments in "userspace pm enhancements" v14.

Geliang Tang (23):
mptcp: add pm_has_addr_attr_id helper
mptcp: add needs_id for userspace appending addr
mptcp: add needs_id for netlink appending addr
mptcp: map v4 address to v6 when destroying subflow
selftests: mptcp: rm subflow with v4/v4mapped addr
mptcp: export mptcp_genl_family & mptcp_nl_fill_addr
mptcp: implement mptcp_userspace_pm_dump_addr
mptcp: add token for get-addr in yaml
mptcp: dump addrs in userspace pm list
mptcp: check userspace pm subflow flag
selftests: mptcp: add userspace pm subflow flag
selftests: mptcp: add token for dump_addr
selftests: mptcp: add check_output helper
selftests: mptcp: dump after creating id 0 subflow
selftests: mptcp: dump userspace addrs list
mptcp: add userspace_pm_lookup_addr_by_id helper
mptcp: implement mptcp_userspace_pm_get_addr
mptcp: get addr in userspace pm list
selftests: mptcp: add token for get_addr
selftests: mptcp: userspace pm get addr tests
mptcp: update set_flags interfaces
mptcp: set error messages for set_flags
selftests: mptcp: flush userspace addrs list

 Documentation/netlink/specs/mptcp_pm.yaml     |   3 +-
 net/mptcp/mptcp_pm_gen.c                      |   7 +-
 net/mptcp/mptcp_pm_gen.h                      |   2 +-
 net/mptcp/pm.c                                |  38 ++-
 net/mptcp/pm_netlink.c                        | 100 ++++----
 net/mptcp/pm_userspace.c                      | 241 +++++++++++++++---
 net/mptcp/protocol.h                          |  25 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 150 ++++++++++-
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  39 ++-
 9 files changed, 505 insertions(+), 100 deletions(-)
Signature · 1 line
2.40.1