Skip to content

kasan: save mempool stack traces

[email protected] linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 1 replyIn review 20 of 21 applied

Changes in v1 from the cover letter

- New patch "mempool: skip slub_debug poisoning when KASAN is enabled".
- Replace mempool_use_prealloc_only API with mempool_alloc_preallocated.
- Avoid triggering slub_debug-detected corruptions in mempool tests.

Patches in v1 20 of 21 applied

#Subject and filesSizeRepliesApplied
1/21kasan: rename kasan_slab_free_mempool to kasan_mempool_poison_objectinclude/linux/kasan.h io_uring/alloc_cache.h mm/kasan/common.c +1 more+8 -90 repliesApplied
2/21kasan: move kasan_mempool_poison_objectinclude/linux/kasan.h mm/kasan/common.c+31 -310 repliesApplied
3/21kasan: document kasan_mempool_poison_objectinclude/linux/kasan.h+18 -00 repliesApplied
4/21kasan: add return value for kasan_mempool_poison_objectinclude/linux/kasan.h mm/kasan/common.c+22 -160 repliesApplied
5/21kasan: introduce kasan_mempool_unpoison_objectinclude/linux/kasan.h mm/kasan/common.c+36 -00 repliesApplied
6/21kasan: introduce kasan_mempool_poison_pagesinclude/linux/kasan.h mm/kasan/common.c+50 -00 repliesApplied
7/21kasan: introduce kasan_mempool_unpoison_pagesinclude/linux/kasan.h mm/kasan/common.c+31 -00 repliesApplied
8/21kasan: clean up __kasan_mempool_poison_objectmm/kasan/common.c+7 -120 repliesApplied
9/21kasan: save free stack traces for slab mempoolsinclude/linux/kasan.h mm/kasan/common.c+12 -130 repliesApplied
10/21kasan: clean up and rename ____kasan_kmallocmm/kasan/common.c+22 -200 repliesApplied
11/21kasan: introduce poison_kmalloc_large_redzonemm/kasan/common.c+23 -180 repliesApplied
12/21kasan: save alloc stack traces for mempoolinclude/linux/kasan.h mm/kasan/common.c+44 -130 repliesApplied
13/21mempool: skip slub_debug poisoning when KASAN is enabledmm/mempool.c+8 -00 repliesApplied
14/21mempool: use new mempool KASAN hooksmm/mempool.c+12 -100 repliesApplied
15/21mempool: introduce mempool_use_prealloc_onlyinclude/linux/mempool.h mm/mempool.c+38 -00 repliesApplied
16/21kasan: add mempool testsmm/kasan/kasan_test.c+319 -00 repliesApplied
17/21kasan: rename pagealloc testsmm/kasan/kasan_test.c+26 -250 repliesApplied
18/21kasan: reorder testsmm/kasan/kasan_test.c+209 -2090 repliesApplied
19/21kasan: rename and document kasan_(un)poison_object_datainclude/linux/kasan.h mm/kasan/common.c mm/slab.c +2 more+39 -220 replies
20/21skbuff: use mempool KASAN hooksnet/core/skbuff.c+6 -40 repliesApplied
21/21io_uring: use mempool KASAN hookio_uring/alloc_cache.h+1 -10 repliesApplied

Reviews trailers per patch

None of the 21 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarco Elver
SeriesA-b
1/21
2/21
3/21
4/21
5/21
6/21
7/21
8/21
9/21
10/21
11/21
12/21
13/21
14/21
15/21
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH mm 00/21] kasan: save mempool stack traces

From: Andrey Konovalov <[email protected]>

This series updates KASAN to save alloc and free stack traces for secondary-level allocators that cache and reuse allocations internally instead of giving them back to the underlying allocator (e.g. mempool).

As a part of this change, introduce and document a set of KASAN hooks:

bool kasan_mempool_poison_pages(struct page *page, unsigned int order); void kasan_mempool_unpoison_pages(struct page *page, unsigned int order); bool kasan_mempool_poison_object(void *ptr);
void kasan_mempool_unpoison_object(void *ptr, size_t size);

and use them in the mempool code.

Besides mempool, skbuff and io_uring also cache allocations and already use KASAN hooks to poison those. Their code is updated to use the new mempool hooks.

The new hooks save alloc and free stack traces (for normal kmalloc and slab objects; stack traces for large kmalloc objects and page_alloc are not supported by KASAN yet), improve the readability of the users' code, and also allow the users to prevent double-free and invalid-free bugs; see the patches for the details.

There doesn't appear to be any conflicts with the KASAN patches that are currently in mm, but I rebased the patchset on top just in case.

Changes RFC->v1:
- New patch "mempool: skip slub_debug poisoning when KASAN is enabled".
- Replace mempool_use_prealloc_only API with mempool_alloc_preallocated.
- Avoid triggering slub_debug-detected corruptions in mempool tests.

Andrey Konovalov (21):
kasan: rename kasan_slab_free_mempool to kasan_mempool_poison_object
kasan: move kasan_mempool_poison_object
kasan: document kasan_mempool_poison_object
kasan: add return value for kasan_mempool_poison_object
kasan: introduce kasan_mempool_unpoison_object
kasan: introduce kasan_mempool_poison_pages
kasan: introduce kasan_mempool_unpoison_pages
kasan: clean up __kasan_mempool_poison_object
kasan: save free stack traces for slab mempools
kasan: clean up and rename ____kasan_kmalloc
kasan: introduce poison_kmalloc_large_redzone
kasan: save alloc stack traces for mempool
mempool: skip slub_debug poisoning when KASAN is enabled
mempool: use new mempool KASAN hooks
mempool: introduce mempool_use_prealloc_only
kasan: add mempool tests
kasan: rename pagealloc tests
kasan: reorder tests
kasan: rename and document kasan_(un)poison_object_data
skbuff: use mempool KASAN hooks
io_uring: use mempool KASAN hook

 include/linux/kasan.h   | 161 +++++++-
 include/linux/mempool.h |   1 +
 io_uring/alloc_cache.h  |   5 +-
 mm/kasan/common.c       | 221 ++++++----
 mm/kasan/kasan_test.c   | 870 +++++++++++++++++++++++++++-------------
 mm/mempool.c            |  67 +++-
 mm/slab.c               |  10 +-
 mm/slub.c               |   4 +-
 net/core/skbuff.c       |  10 +-
 9 files changed, 954 insertions(+), 395 deletions(-)
Signature · 1 line
2.25.1