completion: silence pseudo-ref existence check
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 0 repliesNew
- v12 patches 9 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | completion: discover repo path in `__git_pseudoref_exists ()`contrib/ | +2 | 0 replies | |
| 2/5 | t9902: verify that completion does not print anythingt/ | +10 | 0 replies | |
| 3/5 | completion: improve existence check for pseudo-refscontrib/ | +3 | 0 replies | |
| 4/5 | completion: silence pseudoref existence checkcontrib/ t/ | +32 | 0 replies | |
| 5/5 | completion: treat dangling symrefs as existing pseudorefscontrib/ t/ | +5 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Jeff King | Johannes Schindelin |
|---|---|---|
| 1/5 | ||
| 2/5 | ||
| 3/5 | ||
| 4/5 | Helped-by | Helped-by |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] completion: silence pseudo-ref existence check
Hi,
this is the second version of my patch series that refactors the Bash completion scripts to work better with reftables. Changes compared to v1:
- I've incorporated SZEDER's feedback that he has sent in reply to the original patch series that is already in master. Most importantly, we now discover the repo path in __git_pseudoref_exists () itself.
- I've included some refactorings to stop leaking local variables in
`__git_pseudoref_exists ()`.
- I've added tests for __git_pseudoref_exists () directly, which was also suggested by SZEDER.
- I've marked t9902 with test_untraceable now to unbreak macOS CI.
- I've refactored the completion test to use git show-ref --exists to fix an issue with unborn pseudorefs that I didn't notice previously.
I didn't include a range-diff because quite a lof of things have moved around.
Patrick
Patrick Steinhardt (5):
completion: discover repo path in __git_pseudoref_exists ()
t9902: verify that completion does not print anything
completion: improve existence check for pseudo-refs
completion: silence pseudoref existence check
completion: treat dangling symrefs as existing pseudorefs
contrib/completion/git-completion.bash | 11 +++--- t/t9902-completion.sh | 47 ++++++++++++++++++++++++-- 2 files changed, 50 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.GIT