Skip to content

drm/i915/opregion: better abstractions

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915/bios: move i915_vbt debugfs to intel_bios.cdrivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_bios.h drivers/gpu/drm/i915/display/intel_display_debugfs.c+28 -121 reply
2/6drm/i915/opregion: move i915_opregion debugfs to intel_opregion.cdrivers/gpu/drm/i915/display/intel_display_debugfs.c drivers/gpu/drm/i915/display/intel_opregion.c drivers/gpu/drm/i915/display/intel_opregion.h+28 -121 reply
3/6drm/i915/opregion: abstract getting the opregion VBTdrivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_opregion.c drivers/gpu/drm/i915/display/intel_opregion.h+30 -51 reply
4/6drm/i915/opregion: abstract ASLE presence checkdrivers/gpu/drm/i915/display/intel_display_irq.c drivers/gpu/drm/i915/display/intel_opregion.c drivers/gpu/drm/i915/display/intel_opregion.h+14 -35 replies
5/6drm/i915/gvt: use local INTEL_GVT_OPREGION_SIZEdrivers/gpu/drm/i915/gvt/kvmgt.c+1 -11 reply
6/6drm/i915/opregion: make struct intel_opregion opaquedrivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/display/intel_opregion.c drivers/gpu/drm/i915/display/intel_opregion.h+94 -833 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchRadhakrishna Sripada
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] drm/i915/opregion: better abstractions

Here's some opregion refactoring and abstraction inspired by Radhakrishna's series [1]. This is basically what I want to see done first.

The next step would be to move VBT firmware loading from intel_opregion_setup() to intel_bios_setup(). This probably involves keeping a copy of the VBT around in i915->display.vbt, maybe add vbt and vbt_size members there. This can be used to fix the i915_vbt debugfs file to actually reflect the VBT wherever it came from.

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/128341/

Jani Nikula (6):
drm/i915/bios: move i915_vbt debugfs to intel_bios.c drm/i915/opregion: move i915_opregion debugfs to intel_opregion.c drm/i915/opregion: abstract getting the opregion VBT drm/i915/opregion: abstract ASLE presence check drm/i915/gvt: use local INTEL_GVT_OPREGION_SIZE drm/i915/opregion: make struct intel_opregion opaque

 drivers/gpu/drm/i915/display/intel_bios.c     |  33 +++-
 drivers/gpu/drm/i915/display/intel_bios.h     |   2 +
 .../gpu/drm/i915/display/intel_display_core.h |   3 +-
 .../drm/i915/display/intel_display_debugfs.c  |  26 +--
 .../gpu/drm/i915/display/intel_display_irq.c  |   6 +-
 drivers/gpu/drm/i915/display/intel_opregion.c | 176 +++++++++++++-----
 drivers/gpu/drm/i915/display/intel_opregion.h |  47 +++--
 drivers/gpu/drm/i915/gvt/kvmgt.c              |   2 +-
 8 files changed, 187 insertions(+), 108 deletions(-)
Signature · 1 line
2.39.2