mptcp: locking cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mptcp: drop the push_pending fieldnet/ net/ | +6 | 4 replies | |
| 2/4 | mptcp: fix rcv space initializationnet/ net/ net/ | +10 | 0 replies | |
| 3/4 | mptcp: fix more tx path fields initializationnet/ net/ | +13 | 0 replies | |
| 4/4 | mptcp: corner case locking for rx path fields initializationnet/ net/ net/ +2 more | +50 | 5 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Mat Martineau |
|---|---|
| Series | R-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH mptcp-net 0/4] mptcp: locking cleanup
This is a preparatory work for the TCP_NOTSENT_LOWAT support. The latter will need tracking more state under the msk data lock.
Since the locking msk locking schema is already quite complex, do a long awaited clean-up step, moving several confusing lockless initialization under the relevant locks.
Note that patches 2-4 carry fixes tag, and could target the net tree, but AFACIS no real race could really happen even prior to such patches as the MPTCP-level state machine implicitly ensure proper serialization of the write accesses, even lacking explicit lock.
Patch 1 has no fixes, but still is logically tied to the other patches. Possibly we could target net-next for the whole series.
Paolo Abeni (4):
mptcp: drop the push_pending field
mptcp: fix rcv space initialization
mptcp: fix more tx path fields initialization
mptcp: corner case locking for rx path fields initialization
net/mptcp/fastopen.c | 6 ++-- net/mptcp/options.c | 9 +++--- net/mptcp/protocol.c | 31 ++++++++++--------- net/mptcp/protocol.h | 13 ++++---- net/mptcp/subflow.c | 71 +++++++++++++++++++++++++++----------------- 5 files changed, 75 insertions(+), 55 deletions(-)
Signature · 1 line
2.43.0