Skip to content

btrfs-progs: parser related cleanups

Qu Wenruo linux-btrfs 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 1 replyIn review
  2. v2 posting 1/21 of 2 patches 0 repliesSuperseded
  3. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- Properly return the parsed value for parse_u64_with_suffix() Facepalm, I forgot to assign the result to @value_ret, and only relied on cli-tests to catch them, but they are not enough to catch.

- Avoid outputting any error message inside parse_u64_with_suffix() One error message and exit(1) call is left from previous function. Need to be consistent with all other error situations.

- Rebased using the patch from devel branch
So that the modification David did won't need to be redone.

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs-progs: use parse_u64() to implement arg_strtou64()common/parse-utils.c common/string-utils.c common/string-utils.h+30 -170 replies
2/2btrfs-progs: implement arg_strtou64_with_suffix() with a new helpercmds/filesystem.c cmds/qgroup.c cmds/reflink.c +8 more+88 -510 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] btrfs-progs: parser related cleanups

[CHANGELOG]
v2:
- Properly return the parsed value for parse_u64_with_suffix() Facepalm, I forgot to assign the result to @value_ret, and only relied on cli-tests to catch them, but they are not enough to catch.

- Avoid outputting any error message inside parse_u64_with_suffix() One error message and exit(1) call is left from previous function. Need to be consistent with all other error situations.

- Rebased using the patch from devel branch
So that the modification David did won't need to be redone.

Btrfs-progs has two types of parsers:

- parse_*()
Those would return 0 for a good parse, and save the value into a pointer.
Callers are responsible to handle the error.

- arg_strto*()
Those would directly return the parsed value, and call exit(1) directly for errors.

However this split is not perfect:

- A lot of code can be shared between them
In fact, mostly arg_strto*() can be implement using parse_*(). The only difference is in how detailed the error string would be.

- parse_size_from_string() doesn't follow the scheme It follows arg_strto*() behavior but has the parse_*() name.

This patch would:

- Use parse_u64() to implement arg_strtou64()
The first patch.

- Use parse_u64_with_suffix() to implement arg_strtou64_with_suffix() The new helper parse_u64_with_suffix() would replace the old parse_size_from_string() and do the proper error handling.

Qu Wenruo (2):
btrfs-progs: use parse_u64() to implement arg_strtou64()
btrfs-progs: implement arg_strtou64_with_suffix() with a new helper

 cmds/filesystem.c     | 15 ++++----
 cmds/qgroup.c         |  3 +-
 cmds/reflink.c        |  7 ++--
 cmds/scrub.c          |  2 +-
 common/parse-utils.c  | 90 +++++++++++++++++++++++++++----------------
 common/parse-utils.h  |  2 +-
 common/string-utils.c | 45 ++++++++++++++--------
 common/string-utils.h |  9 +++++
 convert/main.c        |  3 +-
 kernel-shared/zoned.c |  4 +-
 mkfs/main.c           |  6 +--
 11 files changed, 118 insertions(+), 68 deletions(-)

--
2.43.0