Skip to content

btrfs: subvol qgroup lifetime invariants

Boris Burkov linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: forbid creating subvol qgroupsfs/btrfs/ioctl.c+5 -07 replies
2/2btrfs: forbid deleting live subvol qgroupfs/btrfs/qgroup.c+15 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchQu WenruoDavid Sterba
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: subvol qgroup lifetime invariants

Subvol qgroups (id 0/SUBVOLID) are special. They get created and reaped automatically for subvols, and can never have any children by virtue of being at level 0.

Manually managing them doesn't provide much value but does create the possibility for weird states and races. To that end, ban deleting subvol qgroups that still have usage and creating subvol qgroups at all.

Testing Note: this patch series breaks btrfs/303 as that test is hunting a race to do with creating a subvol qgroup which now explicitly fails.

Boris Burkov (2):
btrfs: forbid creating subvol qgroups
btrfs: forbid deleting live subvol qgroup

 fs/btrfs/ioctl.c  |  5 +++++
 fs/btrfs/qgroup.c | 15 +++++++++++++++
 2 files changed, 20 insertions(+)
Signature · 1 line
2.43.0