Skip to content

Make nfs stats visible in network NS

Josef Bacik linux-nfs ltp 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 0 repliesNew
  2. v43 patches 1 replySuperseded
  3. v3 posting 2/23 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/210 patches2 repliesSuperseded
v213 patches16 repliesSuperseded
v12 patches10 repliesSuperseded

Changes in v5 from the cover letter

- If we clone a client pass through their ->cl_stats so it's populated properly.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sunrpc: add a struct rpc_stats arg to rpc_create_argsinclude/linux/sunrpc/clnt.h net/sunrpc/clnt.c+5 -10 replies
2/3nfs: expose /proc/net/sunrpc/nfs in net namespacesfs/nfs/inode.c+2 -40 replies
3/3nfs: make the rpc_stat per net namespacefs/nfs/client.c fs/nfs/inode.c fs/nfs/internal.h +1 more+9 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/3] Make nfs stats visible in network NS

v1: https://lore.kernel.org/linux-nfs/[email protected]/
v2: https://lore.kernel.org/linux-nfs/[email protected]/
v3: https://lore.kernel.org/linux-nfs/[email protected]/
v4: https://lore.kernel.org/linux-nfs/[email protected]/

v4->v5:
- If we clone a client pass through their ->cl_stats so it's populated properly.

v3->v4:
- Fix a weird formatting thing that snuck into 1/3.

v2->v3:
- Split out the nfs and nfsd related changes into their own patches.
- Dropped the change adding sv_stats throuch svc_create()
- Changed the th_cnt to be global, re-arranged it's location.

v1->v2:
- rework the sunprc service creation to take a pointer to the sv_stats.
- dropped ->pg_stats from the svc_program.
- converted all of the nfsd global stats to per-network namespace.
- added the ability to point at a specific rpc_stat for rpc program creation.
- converted the rpc stats for nfs to per-network namespace.

-- Original email --
Hello,

We're currently deploying NFS internally and have run into some oddities with our usage of containers. All of the services that mount and export NFS volumes run inside of containers, specifically all the namespaces including network namespaces. Our monitoring is done on a per-container basis, so we need access to the nfs and nfsd stats that are under /proc/net/sunrpc. However these are only tied to the init_net, which makes them invisible to containers in a different network namespace.

Fix this so that these files are tied to the network namespace. This allows us to avoid the hack of bind mounting the hosts /proc into the container in order to do proper monitoring. Thanks,

Josef

Josef Bacik (3):
sunrpc: add a struct rpc_stats arg to rpc_create_args
nfs: expose /proc/net/sunrpc/nfs in net namespaces
nfs: make the rpc_stat per net namespace

 fs/nfs/client.c             | 5 ++++-
 fs/nfs/inode.c              | 8 ++++----
 fs/nfs/internal.h           | 2 --
 fs/nfs/netns.h              | 2 ++
 include/linux/sunrpc/clnt.h | 1 +
 net/sunrpc/clnt.c           | 5 ++++-
 6 files changed, 15 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0