Skip to content

Error handling fixes

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 25 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20btrfs: handle directory and dentry mismatch in btrfs_may_delete()fs/btrfs/ioctl.c+3 -10 replies
2/20btrfs: handle invalid range and start in merge_extent_mapping()fs/btrfs/extent_map.c+5 -42 replies
3/20btrfs: handle block group lookup error when it's being removedfs/btrfs/block-group.c+3 -14 replies
4/20btrfs: handle root deletion lookup error in btrfs_del_root()fs/btrfs/root-tree.c+5 -22 replies
5/20btrfs: handle invalid root reference found in btrfs_find_root()fs/btrfs/root-tree.c+8 -17 replies
6/20btrfs: handle invalid root reference found in btrfs_init_root_free_objectid()fs/btrfs/disk-io.c+8 -11 reply
7/20btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks()fs/btrfs/volumes.c+11 -11 reply
8/20btrfs: handle invalid extent item reference found in check_committed_ref()fs/btrfs/extent-tree.c+8 -12 replies
9/20btrfs: export: handle invalid inode or root reference in btrfs_get_parent()fs/btrfs/export.c+8 -10 replies
10/20btrfs: delayed-inode: drop pointless BUG_ON in __btrfs_remove_delayed_item()fs/btrfs/delayed-inode.c+0 -20 replies
11/20btrfs: change BUG_ON to assertion when checking for delayed_node rootfs/btrfs/delayed-inode.c+1 -10 replies
12/20btrfs: defrag: change BUG_ON to assertion in btrfs_defrag_leaves()fs/btrfs/defrag.c+1 -10 replies
13/20btrfs: change BUG_ON to assertion in btrfs_read_roots()fs/btrfs/disk-io.c+1 -10 replies
14/20btrfs: change BUG_ON to assertion when verifying lockdep class setupfs/btrfs/locking.c+1 -10 replies
15/20btrfs: change BUG_ON to assertion when verifying root in btrfs_alloc_reserved_file_extent()fs/btrfs/extent-tree.c+1 -10 replies
16/20btrfs: change BUG_ON to assertion in reset_balance_state()fs/btrfs/volumes.c+1 -10 replies
17/20btrfs: unify handling of return values of btrfs_insert_empty_items()fs/btrfs/ctree.c fs/btrfs/file-item.c fs/btrfs/uuid-tree.c+5 -40 replies
18/20btrfs: move transaction abort to the error site in btrfs_delete_free_space_tree()fs/btrfs/free-space-tree.c+10 -90 replies
19/20btrfs: move transaction abort to the error site in btrfs_create_free_space_tree()fs/btrfs/free-space-tree.c+12 -70 replies
20/20btrfs: move transaction abort to the error site btrfs_rebuild_free_space_tree()fs/btrfs/free-space-tree.c+10 -80 replies

Reviews trailers per patch

None of the 20 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosef BacikAnand Jain
SeriesR-b R-b
1/20
2/20
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20
14/20
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] Error handling fixes

Get rid of some easy BUG_ONs, there are a few groups fixing the same pattern. At the end there are three patches that move transaction abort to the right place. I have tested it on my setups only, not the CI, but given the type of fix we'd never hit any of them without special instrumentation.

David Sterba (20):
btrfs: handle directory and dentry mismatch in btrfs_may_delete()
btrfs: handle invalid range and start in merge_extent_mapping()
btrfs: handle block group lookup error when it's being removed
btrfs: handle root deletion lookup error in btrfs_del_root()
btrfs: handle invalid root reference found in btrfs_find_root()
btrfs: handle invalid root reference found in btrfs_init_root_free_objectid()
btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks()
btrfs: handle invalid extent item reference found in check_committed_ref()
btrfs: export: handle invalid inode or root reference in btrfs_get_parent()
btrfs: delayed-inode: drop pointless BUG_ON in __btrfs_remove_delayed_item()
btrfs: change BUG_ON to assertion when checking for delayed_node root
btrfs: defrag: change BUG_ON to assertion in btrfs_defrag_leaves()
btrfs: change BUG_ON to assertion in btrfs_read_roots()
btrfs: change BUG_ON to assertion when verifying lockdep class setup
btrfs: change BUG_ON to assertion when verifying root in btrfs_alloc_reserved_file_extent()
btrfs: change BUG_ON to assertion in reset_balance_state()
btrfs: unify handling of return values of btrfs_insert_empty_items()
btrfs: move transaction abort to the error site in btrfs_delete_free_space_tree()
btrfs: move transaction abort to the error site in btrfs_create_free_space_tree()
btrfs: move transaction abort to the error site btrfs_rebuild_free_space_tree()

 fs/btrfs/block-group.c     |  4 ++-
 fs/btrfs/ctree.c           |  4 +++
 fs/btrfs/defrag.c          |  2 +-
 fs/btrfs/delayed-inode.c   |  4 +--
 fs/btrfs/disk-io.c         | 11 ++++++--
 fs/btrfs/export.c          |  9 +++++-
 fs/btrfs/extent-tree.c     | 11 ++++++--
 fs/btrfs/extent_map.c      |  9 +++---
 fs/btrfs/file-item.c       |  3 --
 fs/btrfs/free-space-tree.c | 56 ++++++++++++++++++++++----------------
 fs/btrfs/ioctl.c           |  4 ++-
 fs/btrfs/locking.c         |  2 +-
 fs/btrfs/root-tree.c       | 16 +++++++++--
 fs/btrfs/uuid-tree.c       |  2 +-
 fs/btrfs/volumes.c         | 14 ++++++++--
 15 files changed, 102 insertions(+), 49 deletions(-)
Signature · 1 line
2.42.1