Skip to content

Fix resource freeing bugs in virtio-gpu-rutabaga

Manos Pitsidianakis qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 7 repliesSuperseded
  3. v13 patches 6 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/display/virtio-gpu.c: use reset_bh class methodhw/display/virtio-gpu.c+1 -10 replies
2/3virtio-gpu.c: add resource_destroy class methodhw/display/virtio-gpu.c include/hw/virtio/virtio-gpu.h+25 -30 replies
3/3virtio-gpu-rutabaga.c: override resource_destroy methodhw/display/virtio-gpu-rutabaga.c+35 -121 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMarc-André LureauGurchetan Singh
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Fix resource freeing bugs in virtio-gpu-rutabaga

While testing the rutabaga gpu device, we noticed that if the device is reset, it stops working and complains about missing resource ids. A quick investigation discovered that the generic VirtIOGPU implementation frees all resources, but for Rutabaga, they are tied with rutabaga objects that need to be destroyed as well.

This series adds a resource_destroy class method that the Rutabaga device can override and do its own bookkeeping.

v2 -> v3 differences:
- use error_setg_errno in virtio-gpu-rutabaga.c
resource_destroy method. (Thanks Marc-André
Lureau <[email protected]> !)

v1 -> v2 differences:
- addressed review comments re: using the Error API for the resource_destroy method.

Manos Pitsidianakis (3):
hw/display/virtio-gpu.c: use reset_bh class method virtio-gpu.c: add resource_destroy class method virtio-gpu-rutabaga.c: override resource_destroy method

 include/hw/virtio/virtio-gpu.h   |  3 ++
 hw/display/virtio-gpu-rutabaga.c | 47 ++++++++++++++++++++++++--------
 hw/display/virtio-gpu.c          | 27 +++++++++++++++---
 3 files changed, 61 insertions(+), 16 deletions(-)

Range-diff against v2:

1:  5893fb45d1 = 1:  87fb4fa72c hw/display/virtio-gpu.c: use reset_bh class method
2:  78b15e8f7e ! 2:  b0a86630c4 virtio-gpu.c: add resource_destroy class method

@@ Commit message
This commit adds a class method so that virtio-gpu-rutabaga can override it in the next commit.

+ Reviewed-by: Marc-André Lureau <[email protected]>

## include/hw/virtio/virtio-gpu.h ##
3: 926db899be ! 3: e3778e44c9 virtio-gpu-rutabaga.c: override resource_destroy method
@@ hw/display/virtio-gpu-rutabaga.c: rutabaga_cmd_create_resource_3d(VirtIOGPU *g,
+ Error **errp)
+{
+ int32_t result;
-+ const char *strerror = NULL;
+ VirtIOGPURutabaga *vr = VIRTIO_GPU_RUTABAGA(g);
+
+ result = rutabaga_resource_unref(vr->rutabaga, res->resource_id);
+ if (result) {
-+ error_setg(errp, "%s: rutabaga_resource_unref returned %"PRIi32
-+ " for resource_id = %"PRIu32, __func__, result,
-+ res->resource_id);
-+ strerror = strerrorname_np((int)result);
-+ if (strerror != NULL) {
-+ error_append_hint(errp, "%s: %s\n",
-+ strerror, strerrordesc_np((int)result) ? : "");
-+ }
++ error_setg_errno(errp,
++ (int)result,
++ "%s: rutabaga_resource_unref returned %"PRIi32
++ " for resource_id = %"PRIu32, __func__, result,
++ res->resource_id);
+ }
+
+ if (res->image) {

base-commit: 11be70677c70fdccd452a3233653949b79e97908

Signature · 1 line
γαῖα πυρί μιχθήτω