config: add back code comment
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest1 patch 0 repliesNew
- v11 patch 2 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | config: add back code commentbuiltin/ | +6 | 0 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Patrick Steinhardt |
|---|---|
| 1/1 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/1] config: add back code comment
This is a follow-up to the kh/maintenance-use-xdg-when-it-should [series] which was merged in 12ee4ed506 (Merge branch 'kh/maintenance-use-xdg-when-it-sho.., 2024-01-26).
I dropped a code comment while iterating on a refactor. It still makes as much sense in this context as before the refactor (it’s a _refactor_ in the sense of “don’t change code behavior”).
The code comment was moved to config.c in patch v1 3/4.[1] But review feedback said that this comment didn’t fit in this new place and that we shouldn’t die() in git_global_config. So in v2 3/4[2] I removed the comment in git_global_config. But I forgot to put the comment back to its original place, where it still makes as much sense as before my series.
See the cover letter on the first version for the diff when I squash this patch into c15129b699 (config: factor out global config file retrieval, 2024-01-18).
Sorry about the churn.
§ Changes in v2
Add an ack trailer.
This is the (tentative) final version. I read (interpreted) SubmittingPatches as saying that the final version should be sent, even though it’s just to add an additional trailer. I’m open for feedback on the submission process of course.
I’ve added it after my signoff since it seems preferred to maintain the chronology (although in this case either choice seems equally clear). Also it seemed more common in the recent Git log.
🔗 series: https://lore.kernel.org/git/[email protected]/
🔗 1: https://lore.kernel.org/git/147c767443c35b3b4a5516bf40557f41bb201078.1697660181.git.code@khaugsbakk.name/
🔗 2: https://lore.kernel.org/git/32e5ec7d866ff8fd26554b325812c6e19cb65126.1705267839.git.code@khaugsbakk.name/
Kristoffer Haugsbakk (1):
config: add back code comment
builtin/config.c | 6 ++++++ 1 file changed, 6 insertions(+)
Range-diff against v1:
1: 48d66e94ec ! 1: 24f536d575 config: add back code comment
@@ Commit message
which explains $HOME not set.
+ Acked-by: Patrick Steinhardt <[email protected]>
## builtin/config.c ##
@@ builtin/config.c: int cmd_config(int argc, const char **argv, const char *prefix)
Signature · 1 line
2.43.0