Skip to content

Ensure FCoE target interrupts work correctly

Lee Duncan linux-scsi lkml 2 versions – Applied

Status from this message: Applied to 6.8/scsi-fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 2 repliesApplied
  2. v12 patches 2 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"drivers/scsi/fcoe/fcoe_ctlr.c+8 -121 reply
2/2fnic: move fnic_fnic_flush_tx() to a work queuedrivers/scsi/fnic/fnic.h drivers/scsi/fnic/fnic_fcs.c drivers/scsi/fnic/fnic_main.c +1 more+8 -50 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchHannes Reinecke
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] Ensure FCoE target interrupts work correctly

From: Lee Duncan <[email protected]>

Commit 1a1975551943 "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock" changed locking for fnic/FCoE, but it did so by disabling interrupts where they weren't disabled before, and this caused FCoE targets to go offline. Reverting that patch fixed the issue.

But to handle the problem originally addressed by the commit, instead of modifying the locking, move the work to be done into a work queue.

Differences in v4:
- Corrected "Fixes" attributes in both patches
- Added identifier name in fnic_flush_tx() prototype, for checkpatch

Differences in v3:
- Added "fixes" clause to the fnic patch, as requested by Hannes

Differences in V2:
- Fix kerneldoc comments in fnic_flush_tx()

Lee Duncan (1):
Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

Hannes Reinecke (1):
fnic: move fnic_fnic_flush_tx() to a work queue

 drivers/scsi/fcoe/fcoe_ctlr.c | 20 ++++++++------------
 drivers/scsi/fnic/fnic.h      |  3 ++-
 drivers/scsi/fnic/fnic_fcs.c  |  5 +++--
 drivers/scsi/fnic/fnic_main.c |  1 +
 drivers/scsi/fnic/fnic_scsi.c |  4 ++--
 5 files changed, 16 insertions(+), 17 deletions(-)
Signature · 1 line
2.35.3