Ioctl buffer name/path validation
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: factor out validation of btrfs_ioctl_vol_args::namefs/ fs/ fs/ | +35 | 0 replies | |
| 2/3 | btrfs: factor out validation of btrfs_ioctl_vol_args_v2::namefs/ | +17 | 0 replies | |
| 3/3 | btrfs: dev-replace: properly validate device namesfs/ | +20 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | [email protected] | Boris Burkov |
|---|---|---|
| Series | R-b | |
| 1/3 | ||
| 2/3 | ||
| 3/3 | Reported-and-tested-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] Ioctl buffer name/path validation
This is inspired by a report and fix [1] where device replace buffers were not properly validated (third patch). The other two are doing proper validation of vol args path or name so that an unterminated string is reported as an error rather than relying on later actions like open that would catch an invalid path.
(I'm OK to replace the third patch in favor of Edward as he spent time analyzing it but we did not agree on a fix and I did not get a reply with the suggestion I implemented in the end.)
[1] https://lore.kernel.org/linux-btrfs/[email protected]/
David Sterba (3):
btrfs: factor out validation of btrfs_ioctl_vol_args::name
btrfs: factor out validation of btrfs_ioctl_vol_args_v2::name
btrfs: dev-replace: properly validate device names
fs/btrfs/dev-replace.c | 24 +++++++++++++++---- fs/btrfs/fs.h | 2 ++ fs/btrfs/ioctl.c | 54 +++++++++++++++++++++++++++++++++++------- fs/btrfs/super.c | 5 +++- 4 files changed, 72 insertions(+), 13 deletions(-)
Signature · 1 line
2.42.1