Skip to content

MCTP core protocol updates, minor fixes & tests

Jeremy Kerr netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 0 repliesApplied 11/11
  2. v111 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- [06/11] fix forwards-compat check on local_peer, based on feedback from Dan Carpenter <[email protected]>
- [10/11] don't skip the flow tests for a kunit all-tests run, based on feedback from Jakub Kicinski <[email protected]>

Patches in v2 All 11 applied

#Subject and filesSizeRepliesApplied
1/11net: mctp: avoid confusion over local/peer dest/source addressesinclude/net/mctp.h net/mctp/af_mctp.c net/mctp/route.c+11 -110 repliesApplied
2/11net: mctp: Add some detail on the key allocation implementationnet/mctp/route.c+37 -00 repliesApplied
3/11net: mctp: make key lookups match the ANY address on either local or peernet/mctp/route.c+11 -30 repliesApplied
4/11net: mctp: tests: create test skbs with the correct net and devicenet/mctp/test/route-test.c net/mctp/test/utils.c+17 -80 repliesApplied
5/11net: mctp: separate key correlation across netsinclude/net/mctp.h net/mctp/af_mctp.c net/mctp/route.c +1 more+40 -160 repliesApplied
6/11net: mctp: provide a more specific tag allocation ioctlinclude/uapi/linux/mctp.h net/mctp/af_mctp.c+129 -200 repliesApplied
7/11net: mctp: tests: Add netid argument to __mctp_route_test_initnet/mctp/test/route-test.c+7 -40 repliesApplied
8/11net: mctp: tests: Add MCTP net isolation testsnet/mctp/test/route-test.c+161 -00 repliesApplied
9/11net: mctp: copy skb ext data when fragmentingnet/core/skbuff.c net/mctp/route.c+11 -00 repliesApplied
10/11net: mctp: tests: Test that outgoing skbs have flow data populatednet/mctp/Kconfig net/mctp/test/route-test.c tools/testing/kunit/configs/all_tests.config+138 -00 repliesApplied
11/11net: mctp: tests: Add a test for proper tag creation on local outputnet/mctp/test/route-test.c+75 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 00/11] MCTP core protocol updates, minor fixes & tests

This series implements some procotol improvements for AF_MCTP, particularly for systems with multiple MCTP networks defined. For those, we need to add the network ID to the tag lookups, which then suggests an updated version of the tag allocate / drop ioctl to allow the net ID to be specified there too.

The ioctl change affects uabi, so might warrant some extra attention.

There are also a couple of new kunit tests for multiple-net configurations.

We have a fix for populating the flow data when fragmenting, and a testcase for that too.

Of course, any queries/comments/etc., please let me know!

Cheers,

Jeremy

---
v2:
- [06/11] fix forwards-compat check on local_peer, based on feedback from Dan Carpenter <[email protected]>
- [10/11] don't skip the flow tests for a kunit all-tests run, based on feedback from Jakub Kicinski <[email protected]>

---
Jeremy Kerr (11):
net: mctp: avoid confusion over local/peer dest/source addresses
net: mctp: Add some detail on the key allocation implementation
net: mctp: make key lookups match the ANY address on either local or
peer
net: mctp: tests: create test skbs with the correct net and device
net: mctp: separate key correlation across nets
net: mctp: provide a more specific tag allocation ioctl
net: mctp: tests: Add netid argument to __mctp_route_test_init
net: mctp: tests: Add MCTP net isolation tests
net: mctp: copy skb ext data when fragmenting
net: mctp: tests: Test that outgoing skbs have flow data populated
net: mctp: tests: Add a test for proper tag creation on local output

 include/net/mctp.h                           |   6 +-
 include/uapi/linux/mctp.h                    |  32 ++
 net/core/skbuff.c                            |   8 +
 net/mctp/Kconfig                             |   1 +
 net/mctp/af_mctp.c                           | 117 +++++-
 net/mctp/route.c                             | 105 ++++-
 net/mctp/test/route-test.c                   | 413 ++++++++++++++++++-
 net/mctp/test/utils.c                        |   2 +
 tools/testing/kunit/configs/all_tests.config |   1 +
 9 files changed, 630 insertions(+), 55 deletions(-)
Signature · 1 line
2.39.2