Skip to content

make the hugetlb migration strategy consistent

Baolin Wang linux-mm lkml 2 versions – Applied

Status from this message: [merged mm-stable] docs-hugetlbpagerst-add-hugetlb-migration-description.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied 3/3
  2. v13 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Add reviewed tag from Oscar.
- Move the gfp_mask modification into a new helper called by alloc_migration_target().

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3mm: record the migration reason for struct migration_target_controlmm/gup.c mm/internal.h mm/memory-failure.c +5 more+9 -10 repliesApplied
2/3mm: hugetlb: make the hugetlb migration strategy consistentinclude/linux/hugetlb.h mm/hugetlb.c mm/mempolicy.c +1 more+49 -61 replyApplied
3/3docs: hugetlbpage.rst: add hugetlb migration descriptionDocumentation/admin-guide/mm/hugetlbpage.rst+7 -00 repliesApplied

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchOscar Salvador
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] make the hugetlb migration strategy consistent

Hi,

As discussed in previous thread [1], there is an inconsistency when handling hugetlb migration. When handling the migration of freed hugetlb, it prevents fallback to other NUMA nodes in alloc_and_dissolve_hugetlb_folio(). However, when dealing with in-use hugetlb, it allows fallback to other NUMA nodes in alloc_hugetlb_folio_nodemask(), which can break the per-node hugetlb pool and might result in unexpected failures when node bound workloads doesn't get what is asssumed available.

This patch set tries to make the hugetlb migration strategy more clear and consistent. Please find details in each patch.

[1]
https://lore.kernel.org/all/6f26ce22d2fcd523418a085f2c588fe0776d46e7.1706794035.git.baolin.wang@linux.alibaba.com/

Changes from v1:
- Add reviewed tag from Oscar.
- Move the gfp_mask modification into a new helper called by alloc_migration_target().

Changes from RFC:
- Move the gfp modification into alloc_migrate_hugetlb_folio().
- Add more comments.

Baolin Wang (3):
mm: record the migration reason for struct migration_target_control
mm: hugetlb: make the hugetlb migration strategy consistent
docs: hugetlbpage.rst: add hugetlb migration description

 Documentation/admin-guide/mm/hugetlbpage.rst |  7 ++++
 include/linux/hugetlb.h                      | 35 ++++++++++++++++++--
 mm/gup.c                                     |  1 +
 mm/hugetlb.c                                 | 14 ++++++--
 mm/internal.h                                |  1 +
 mm/memory-failure.c                          |  1 +
 mm/memory_hotplug.c                          |  1 +
 mm/mempolicy.c                               |  4 ++-
 mm/migrate.c                                 |  4 ++-
 mm/page_alloc.c                              |  1 +
 mm/vmscan.c                                  |  3 +-
 11 files changed, 65 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.3