Skip to content

builtin/clone: allow remote helpers to detect repo

Patrick Steinhardt git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2refs/reftable: don't fail empty transactions in repo without HEADrefs/reftable-backend.c t/t0610-reftable-basics.sh+14 -08 replies
2/2builtin/clone: allow remote helpers to detect repobuiltin/clone.c setup.c t/t5801/git-remote-testgit+59 -14 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] builtin/clone: allow remote helpers to detect repo

Hi,

this patch series addresses a regression reported by Mike in Git v2.44 where remote helpers cannot access the Git repository anymore when running git-clone(1).

The root cause of this is that we have started to initialize the refdb at a later point, after the helper is spawned. This is required such that we can initialize it with the correct object format, which fixes clones of SHA256 repositories with the reftable format and when using bundles.

The proposed fix here is to partially initialize the refdb with just enough data such that it can be discovered. The fix isn't pretty, but addresses the issue. I also couldn't come up with a better idea than this.

Patrick

Patrick Steinhardt (2):
refs/reftable: don't fail empty transactions in repo without HEAD builtin/clone: allow remote helpers to detect repo

 builtin/clone.c            | 46 ++++++++++++++++++++++++++++++++++++++
 refs/reftable-backend.c    |  1 +
 setup.c                    |  9 +++++++-
 t/t0610-reftable-basics.sh | 13 +++++++++++
 t/t5801/git-remote-testgit |  5 +++++
 5 files changed, 73 insertions(+), 1 deletion(-)

base-commit: a2082dbdd315aa4dd3f315545e5b3ab3b3e2d894

Signature · 1 line
2.44.0